Merge remote-tracking branch 'origin/main' into m-115b-tmp

Merge pull request #126 from JMR-dev/ci/baseline-counter-precision
Count the annotation, not the comment saying a test does not carry it
2026-08-25 23:57:17 -05:00 · 2026-08-25 23:49:01 -05:00 · 2026-08-25 23:24:54 -05:00 · 2026-08-25 23:24:29 -05:00 · 2026-08-25 21:07:28 -05:00
1 changed files with 9 additions and 6 deletions
@@ -130,10 +130,10 @@ install for code that can never run — and on API 37 the full APK does not fit
 - The `model` package is excluded from `ReturnCount` and `CyclomaticComplexMethod` only. It is the
  decision layer, where one branch is one documented user-visible outcome and the metric counts
  answers rather than complexity. Every other rule still applies there.
- **Coverage is reported, not gated** — **69.2% of lines (1519/2194), 53.2% of branches**,
-  measured 2026-08-24 with `./gradlew :app:jacocoTestReport`.
+- **Coverage is reported, not gated** — **84.9% of lines (1971/2321), 63.8% of branches**,
+  measured 2026-08-26 with `./gradlew :app:jacocoTestReport`, against 454 JVM tests in 67 classes.

-  **Every figure this file carried before that date was an artifact, roughly half the real one.**
+  **Every figure this file carried before 2026-08-24 was an artifact, roughly half the real one.**
  Robolectric loads classes through its own sandbox classloader with no source location, JaCoCo
  skips no-location classes by default, and nothing told it otherwise — so **not one Robolectric
  test counted**, and Robolectric is what exercises the framework edge here. The
@@ -147,9 +147,12 @@ install for code that can never run — and on API 37 the full APK does not fit
  disproportionately Robolectric, so each one added denominator and no numerator — the measurement
  was punishing exactly the tests that were hardest to write.

-  Two things still hold. A floor needs a baseline that has settled, and this one has now moved by
-  39 points in a single build change, so it has not. And **re-measure before quoting** — that
-  instruction is the only reason this was caught.
+  Two things still hold. A floor needs a baseline that has settled, and this one has not: it moved
+  39 points in a single build change on 2026-08-24, then another 16 as the #52 test push and the
+  fixes it turned up landed — 69.2% -> 84.9% line, 53.2% -> 63.8% branch — while the denominator
+  grew 2194 -> 2321, because that work added production code of its own. And **re-measure before
+  quoting**: this entry was written quoting 81.4%, measured four hours earlier, and was already
+  three points stale by the time it was ready to merge.
 - **Testable code is not done until it is tested.** If a piece is unit testable, it gets unit
  tests before it counts as done. If it is e2e testable, it gets e2e tests. Both clauses apply —
  a change that is both needs both.
Author	SHA1	Message	Date
JMR-dev	c6b581ab5a	Merge remote-tracking branch 'origin/main' into m-115b-tmp	2026-08-25 23:57:17 -05:00
Jason Ross	34641df19d	Merge pull request #126 from JMR-dev/ci/baseline-counter-precision Count the annotation, not the comment saying a test does not carry it	2026-08-25 23:49:01 -05:00
JMR-devandClaude Opus 5	4f1a007b58	Quote the settled figure, now that the work it was waiting on has landed This PR was opened quoting 81.4%, measured on `b53f326`. Holding it until #116, #117, #119, #121 and #124 merged was the point: by the time it was ready the number had moved three points, which is the same staleness the entry is about. Measured on `93ebfa6` with ./gradlew :app:jacocoTestReport: LINE 1971/2321 84.9% (81.4% four hours earlier, 69.2% on 2026-08-24) BRANCH 900/1410 63.8% (60.2%, then 53.2%) 454 JVM tests in 67 classes, all green. The note now says the entry went stale while it was open, because that is a better argument for the rule than the rule restating itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-25 23:24:54 -05:00
JMR-dev	bf78e06969	Merge remote-tracking branch 'origin/main' into m-115-tmp	2026-08-25 23:24:29 -05:00
JMR-devandClaude Opus 5	68f841e84f	Re-measure coverage, because the figure here was quoted from before the test push CLAUDE.md's own rule is "re-measure before quoting", and the figure it carried was measured on 2026-08-24 -- before the #52 children, the MediaProbe and codec tests, and the guards from #100/#107 landed. Quoting it now would understate the suite by twelve points, which is the same failure the bullet directly below it was written to describe. Measured on `b53f326` with ./gradlew :app:jacocoTestReport: LINE 1847/2268 81.4% (was 1519/2194, 69.2%) BRANCH 837/1390 60.2% (was 53.2%) against 417 JVM tests in 60 classes, all green. The denominator moved too, 2194 -> 2268: the same push added production code of its own, so this is not a pure numerator gain and the note now says so. The Robolectric/isIncludeNoLocationClasses history is left exactly as it was -- it explains why every pre-2026-08-24 figure was an artifact, and that is still the most useful thing in the entry. "That date" is now spelled out, since the headline date above it has moved and the phrase no longer points at itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-25 21:07:28 -05:00