feat(accountsetup): warn against using account password for app password #194

Merged
JMR-dev merged 3 commits from feat-160-app-password-disclaimer into main 2026-07-03 04:40:50 +00:00
JMR-dev commented 2026-07-03 03:30:11 +00:00 (Migrated from github.com)

Summary

  • Adds a new disclaimer string, shown as supportingText directly under the "App password" field on AppPasswordSetupScreen.kt — the shared guided-setup screen for every preset provider with pre-filled IMAP/SMTP servers (Gmail, Yahoo, iCloud, AOL).
  • Text (exact, per issue): "Do not try to use your account password. It will not work. You must use an app password."
  • Placed right where the user is about to type (next to app_password_field), not only in the intro InfoCards above — addresses new users who commonly try their regular account password first and get a confusing auth failure.
  • ManualSetupScreen.kt is untouched, as scoped: its password field is already labeled "Password or app password" and some manually configured IMAP servers do use the account password, so the blanket disclaimer wouldn't be universally true there.

Test plan

  • Added appPasswordSetup_showsAccountPasswordDisclaimerNearField to OnboardingFlowTest.kt (androidTest, compiled only per repo convention — not run on-device here), asserting the new supporting text renders and is scrollable-to next to the app-password field on the Gmail preset (screen is shared by all providers, so one check covers Gmail/Yahoo/iCloud/AOL per the issue's scope note).
  • :app:assembleDebug
  • :app:testDebugUnitTest
  • :app:lintDebug
  • :app:ktlintCheck :app:detekt
  • :app:compileDebugAndroidTestKotlin

Closes #160

🤖 Generated with Claude Code

## Summary - Adds a new disclaimer string, shown as `supportingText` directly under the "App password" field on `AppPasswordSetupScreen.kt` — the shared guided-setup screen for every preset provider with pre-filled IMAP/SMTP servers (Gmail, Yahoo, iCloud, AOL). - Text (exact, per issue): "Do not try to use your account password. It will not work. You must use an app password." - Placed right where the user is about to type (next to `app_password_field`), not only in the intro `InfoCard`s above — addresses new users who commonly try their regular account password first and get a confusing auth failure. - `ManualSetupScreen.kt` is untouched, as scoped: its password field is already labeled "Password or app password" and some manually configured IMAP servers do use the account password, so the blanket disclaimer wouldn't be universally true there. ## Test plan - [x] Added `appPasswordSetup_showsAccountPasswordDisclaimerNearField` to `OnboardingFlowTest.kt` (androidTest, compiled only per repo convention — not run on-device here), asserting the new supporting text renders and is scrollable-to next to the app-password field on the Gmail preset (screen is shared by all providers, so one check covers Gmail/Yahoo/iCloud/AOL per the issue's scope note). - [x] `:app:assembleDebug` - [x] `:app:testDebugUnitTest` - [x] `:app:lintDebug` - [x] `:app:ktlintCheck :app:detekt` - [x] `:app:compileDebugAndroidTestKotlin` Closes #160 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.