JMR-devandClaude Opus 4.8
047391d01c
Add an authenticated admin API to the ingest Worker so the single maintainer
can review the pending queue and pull a report before Friday's publish run.
Endpoints (on the existing handler):
GET /v1/admin/reports list pending report ids
POST /v1/admin/reports/{id}/remove mark a report removed
DELETE /v1/admin/reports/{id} remove alias
Remove calls lifecycle.MarkRemoved (#10), transitioning pending -> removed so
#13's ListPending excludes it from the next publish. Codes: 200 list/remove,
404 unknown id, 401 missing/bad/unset-secret token, 405 wrong method.
Auth: shared-secret Bearer token compared with crypto/subtle.ConstantTimeCompare,
fail-closed when the secret is unset. Injected via handler.New's new AdminBackend
arg: the dev server and tests wire a memory-backed lifecycle.Manager + ADMIN_TOKEN
env; the Worker reads ADMIN_TOKEN from Secrets Store and builds an R2-backed
Manager per request. Choice documented in docs/decisions/admin-auth.md.
Tests: Go httptest unit tests (list, remove+exclusion, 404, 401 incl. fail-closed,
405) and a Bruno api-tests flow (seed, authed list/remove, exclusion, no/bad
token 401). wrangler.jsonc gains only the ADMIN_TOKEN secret binding; worker
triggers untouched (owned by #13).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
109 lines
3.2 KiB
Go
109 lines
3.2 KiB
Go
package handler
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/JMR-dev/LibreMail-Bug-Report-Ingest/internal/ingest"
|
|
)
|
|
|
|
// doRequest runs a single request through the handler and returns the recorder.
|
|
func doRequest(t *testing.T, method, target string) *httptest.ResponseRecorder {
|
|
t.Helper()
|
|
req := httptest.NewRequest(method, target, nil)
|
|
rec := httptest.NewRecorder()
|
|
New(nil, nil).ServeHTTP(rec, req)
|
|
return rec
|
|
}
|
|
|
|
// decode parses the JSON response body or fails the test.
|
|
func decode(t *testing.T, rec *httptest.ResponseRecorder) response {
|
|
t.Helper()
|
|
var got response
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
|
|
t.Fatalf("response body is not valid JSON: %v (body=%q)", err, rec.Body.String())
|
|
}
|
|
return got
|
|
}
|
|
|
|
func TestRoot(t *testing.T) {
|
|
rec := doRequest(t, http.MethodGet, "/")
|
|
|
|
if rec.Code != http.StatusOK {
|
|
t.Fatalf("GET / status = %d, want %d", rec.Code, http.StatusOK)
|
|
}
|
|
if ct := rec.Header().Get("Content-Type"); ct != "application/json; charset=utf-8" {
|
|
t.Errorf("GET / Content-Type = %q, want application/json; charset=utf-8", ct)
|
|
}
|
|
got := decode(t, rec)
|
|
if got.Status != "ok" {
|
|
t.Errorf("GET / status field = %q, want ok", got.Status)
|
|
}
|
|
if got.Service != serviceName {
|
|
t.Errorf("GET / service field = %q, want %q", got.Service, serviceName)
|
|
}
|
|
if got.Message == "" {
|
|
t.Error("GET / message field is empty, want a hello message")
|
|
}
|
|
}
|
|
|
|
func TestHealthz(t *testing.T) {
|
|
rec := doRequest(t, http.MethodGet, "/healthz")
|
|
|
|
if rec.Code != http.StatusOK {
|
|
t.Fatalf("GET /healthz status = %d, want %d", rec.Code, http.StatusOK)
|
|
}
|
|
got := decode(t, rec)
|
|
if got.Status != "ok" {
|
|
t.Errorf("GET /healthz status field = %q, want ok", got.Status)
|
|
}
|
|
}
|
|
|
|
func TestUnknownPathReturns404(t *testing.T) {
|
|
rec := doRequest(t, http.MethodGet, "/does-not-exist")
|
|
|
|
if rec.Code != http.StatusNotFound {
|
|
t.Fatalf("GET /does-not-exist status = %d, want %d", rec.Code, http.StatusNotFound)
|
|
}
|
|
got := decode(t, rec)
|
|
if got.Status != "error" {
|
|
t.Errorf("404 status field = %q, want error", got.Status)
|
|
}
|
|
}
|
|
|
|
// TestReportsRoutedToInjectedSink proves New wires the injected sink into
|
|
// POST /v1/reports (the #9 storage seam), returning 202 and storing the report.
|
|
func TestReportsRoutedToInjectedSink(t *testing.T) {
|
|
sink := &ingest.MemorySink{}
|
|
h := New(sink, nil)
|
|
|
|
body := `{"appVersion":"1.0.0","platform":"android","report":"boom"}`
|
|
req := httptest.NewRequest(http.MethodPost, "/v1/reports", strings.NewReader(body))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
rec := httptest.NewRecorder()
|
|
h.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusAccepted {
|
|
t.Fatalf("POST /v1/reports status = %d, want %d", rec.Code, http.StatusAccepted)
|
|
}
|
|
if sink.Len() != 1 {
|
|
t.Fatalf("injected sink stored %d reports, want 1", sink.Len())
|
|
}
|
|
}
|
|
|
|
func TestNonGetReturns405(t *testing.T) {
|
|
for _, path := range []string{"/", "/healthz"} {
|
|
rec := doRequest(t, http.MethodPost, path)
|
|
|
|
if rec.Code != http.StatusMethodNotAllowed {
|
|
t.Errorf("POST %s status = %d, want %d", path, rec.Code, http.StatusMethodNotAllowed)
|
|
}
|
|
if allow := rec.Header().Get("Allow"); allow != http.MethodGet {
|
|
t.Errorf("POST %s Allow header = %q, want GET", path, allow)
|
|
}
|
|
}
|
|
}
|