<!-- Thanks for contributing! -->
## The purpose of this PR is:
...
- To remove NodeDOMException
- Verify this package works with modern versions of Node.js
-
## This is what had to change:
...
- Update package dependencies
- Update tests to confirm functionality
- Update to pnpm for more performant development and modern package management
-
## This is what like reviewers to know:
...
-------------------------------------------------------------------------------------------------
<!-- Mark what you have done with [x], Remove unnecessary ones. Add new tasks that may fit (like TODO's) -->
- [x] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): `
- [x] I updated the README.md
- [x] I Added unit test(s)
-------------------------------------------------------------------------------------------------
<!-- Add a `- fix #_NUMBER_` line for every Issue this PR solves. Do not comma separate them -->
- fix #000
copilot-pull-request-reviewer[bot]
(Migrated from github.com)
reviewed 2025-07-25 20:28:52 +00:00
copilot-pull-request-reviewer[bot]
(Migrated from github.com)
left a comment
Copy Link
Copy Source
Pull Request Overview
This PR removes the deprecated node-domexception dependency and modernizes the project to work with current Node.js versions. The primary goal is to eliminate deprecated packages while maintaining functionality.
Key changes:
Removed the node-domexception dependency completely
Updated package metadata and renamed to fetch-blob-fixed
Migrated from npm to pnpm for package management
Updated CI configuration to test on newer Node.js versions (18, 20, 22)
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Modernizes test code with improved Float16Array polyfill and debugging
test/test-wpt-in-node.test.js
New test file with comprehensive TypedArray testing
README.md
Updates documentation to reflect the fork and migration to pnpm
.github/workflows/ci.yml
Updates CI to use pnpm and test newer Node.js versions
.npmrc
Removes npm-specific configuration
.vscode/settings.json
Adds spell check configuration
test/own-misc-test.js
Fixes spelling error in test description
Files not reviewed (1)
pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
## Pull Request Overview
This PR removes the deprecated `node-domexception` dependency and modernizes the project to work with current Node.js versions. The primary goal is to eliminate deprecated packages while maintaining functionality.
Key changes:
- Removed the `node-domexception` dependency completely
- Updated package metadata and renamed to `fetch-blob-fixed`
- Migrated from npm to pnpm for package management
- Updated CI configuration to test on newer Node.js versions (18, 20, 22)
### Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
<details>
<summary>Show a summary per file</summary>
| File | Description |
| ---- | ----------- |
| package.json | Removes deprecated dependency, updates devDependencies, adds pnpm configuration |
| from.js | Removes the import of `node-domexception` |
| test/test-wpt-in-node.js | Modernizes test code with improved Float16Array polyfill and debugging |
| test/test-wpt-in-node.test.js | New test file with comprehensive TypedArray testing |
| README.md | Updates documentation to reflect the fork and migration to pnpm |
| .github/workflows/ci.yml | Updates CI to use pnpm and test newer Node.js versions |
| .npmrc | Removes npm-specific configuration |
| .vscode/settings.json | Adds spell check configuration |
| test/own-misc-test.js | Fixes spelling error in test description |
</details>
<details>
<summary>Files not reviewed (1)</summary>
* **pnpm-lock.yaml**: Language not supported
</details>
<details>
<summary>Comments suppressed due to low confidence (1)</summary>
</details>
Debug console.log statements should be removed from production code. These logging statements appear to be temporary debugging code.
const result = await blob.text();
Debug console.log statements should be removed from production code. These logging statements appear to be temporary debugging code.
```suggestion
const result = await blob.text();
```
The comment 'Approximate expected output' suggests uncertainty about the expected result. This could lead to unreliable tests. Consider using precise expected values based on the actual Float16Array encoding.
The comment 'Approximate expected output' suggests uncertainty about the expected result. This could lead to unreliable tests. Consider using precise expected values based on the actual Float16Array encoding.
```suggestion
expected: String.fromCharCode(
Math.round(2.65625 * 1024) & 0xFFFF,
Math.round(58.59375 * 1024) & 0xFFFF
), // Precise expected output based on polyfill logic
```
JMR-dev
(Migrated from github.com)
reviewed 2025-07-25 20:31:30 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The purpose of this PR is:
...
To remove NodeDOMException
Verify this package works with modern versions of Node.js
This is what had to change:
...
This is what like reviewers to know:
...
docs:,fix(area):,feat(area):orbreaking(area):Pull Request Overview
This PR removes the deprecated
node-domexceptiondependency and modernizes the project to work with current Node.js versions. The primary goal is to eliminate deprecated packages while maintaining functionality.Key changes:
node-domexceptiondependency completelyfetch-blob-fixedReviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
node-domexceptionFiles not reviewed (1)
Comments suppressed due to low confidence (1)
@@ -1,54 +1,52 @@{The version string has an extra backtick character. It should be "1.0.0" instead of "1.0.0`".
@@ -1,146 +1,213 @@// Don't want to use the FileReader, don't want to lowerCase the type eitherCommented-out code should be removed instead of left in the codebase. If this assertion is no longer needed, delete it entirely.
Debug console.log statements should be removed from production code. These logging statements appear to be temporary debugging code.
@@ -0,0 +1,234 @@import { File, Blob } from '../from.js'The comment 'Approximate expected output' suggests uncertainty about the expected result. This could lead to unreliable tests. Consider using precise expected values based on the actual Float16Array encoding.
@@ -1,146 +1,213 @@// Don't want to use the FileReader, don't want to lowerCase the type eitherCode is still needed, uncommenting