Fix duplicate DialogManager methods and make tooling Python 3.14-aware #48

Merged
JMR-dev merged 1 commits from fix-dialogmanager-py314-sync into develop 2026-06-21 02:30:28 +00:00
1 Commits
Author SHA1 Message Date
JMR-devandClaude Opus 4.8 7c182047bb Fix duplicate DialogManager methods and make tooling Python 3.14-aware
DialogManager defined show_transfer_stats and show_disable_debugging_reminder
twice; the later definitions silently shadowed the earlier ones. The live
show_transfer_stats(self, stats, operation) accepted only two arguments, but
TransferManager passed a third (deduplicator), raising TypeError inside the Tk
after() callback so the transfer-stats window never appeared after folder
transfers. The shadowed copies were also dead: they indexed stats keys
(bytes_saved/total_files/...) that the *_with_dedup TODO stubs never produce,
so they would have KeyError'd on the real {"message": ...} payload.

- Remove the dead, shadowed copies of both methods
- Drop the unused deduplicator argument at the caller (transfer_manager)
- Annotate the surviving methods with -> None

Also align linting/type config with the existing >=3.13,<3.15 support that CI
already exercises: black now targets py313+py314, and CLAUDE.md documents
3.13/3.14. mypy stays pinned to the 3.13 floor (the oldest supported runtime).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-20 21:22:49 -05:00