JMR-dev/android-assistant
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity
190 Commits 7 Branches 1 Tag
develop
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
JMR-devandClaude Opus 4.8 8020bede3a Fix duplicate DialogManager methods and make tooling Python 3.14-aware 
DialogManager defined show_transfer_stats and show_disable_debugging_reminder
twice; the later definitions silently shadowed the earlier ones. The live
show_transfer_stats(self, stats, operation) accepted only two arguments, but
TransferManager passed a third (deduplicator), raising TypeError inside the Tk
after() callback so the transfer-stats window never appeared after folder
transfers. The shadowed copies were also dead: they indexed stats keys
(bytes_saved/total_files/...) that the *_with_dedup TODO stubs never produce,
so they would have KeyError'd on the real {"message": ...} payload.

- Remove the dead, shadowed copies of both methods
- Drop the unused deduplicator argument at the caller (transfer_manager)
- Annotate the surviving methods with -> None

Also align linting/type config with the existing >=3.13,<3.15 support that CI
already exercises: black now targets py313+py314, and CLAUDE.md documents
3.13/3.14. mypy stays pinned to the 3.13 floor (the oldest supported runtime).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-06-20 21:30:27 -05:00
JMR-dev 986eda94f9 fix status checks 2025-10-18 00:36:55 -05:00
JMR-dev 7d15397a9b set up docker compose setup 2025-10-18 00:36:55 -05:00
JMR-dev 3b5a77da83 remove status checks to get release out the door for now 2025-10-17 14:15:29 -05:00
JMR-dev ea9d9ea835 fixing workflow permissions 2025-10-17 14:05:38 -05:00
JMR-dev b7aa6a0898 fix sync wiki 2025-10-17 14:05:38 -05:00
JMR-dev 94351ddb53 remove unecessary permissions from status check workflow 2025-10-17 14:05:38 -05:00
JMR-dev 47d22e4556 make release workflow usable 2025-10-17 14:05:38 -05:00
JMR-dev 44c5f3cb1f make release workflow usable 2025-10-17 14:05:38 -05:00
JMR-dev a15926b990 Merge branch 'main' into develop 
- Merging main back into develop to give main the status check file necessary for release
 2025-10-17 12:48:36 -05:00
JMR-dev 62af5130bd Add status checks workflow to main 2025-10-17 12:39:26 -05:00
JMR-dev 13c46f410a changed merge strategy to rebase to maintain linear history 2025-10-17 12:10:48 -05:00
JMR-dev 1525d9d8ed remove race condition by making it only possible to start from version bump or merge to main 2025-10-17 12:10:48 -05:00
JMR-dev ee36732236 added error handling and semver format verification for release number in jobs" 2025-10-17 10:22:17 -05:00
JMR-dev fdc329c8c9 update to keep single source of truth for release version number 2025-10-17 10:22:17 -05:00
JMR-dev 152c139e81 add git notes automation for record keeping of rollbacks 2025-10-16 21:28:10 -05:00
JMR-dev 45ec303869 change to reset for rollback strategy for clean rollback 2025-10-16 21:28:10 -05:00
JMR-dev 35bf262da5 fixed version number so that it is option but has error handling and addressed potential infinite retry loop 2025-10-16 20:17:07 -05:00
JMR-dev 8556de0efb release workflow fixes and updates 2025-10-16 19:59:54 -05:00
JMR-dev 7e5ae3472d change auth type for PR creation during release 2025-10-16 18:58:34 -05:00
JMR-dev 4e6c06690d update claude.md 2025-10-16 18:51:32 -05:00
JMR-dev 0053765e99 final touches on release file 2025-10-16 18:51:32 -05:00
JMR-dev 240b27bc9b fixed problems with Arch dockerfile 2025-10-16 18:51:32 -05:00
JMR-dev 5811d587f6 one more time x3 2025-10-16 18:51:32 -05:00
JMR-dev e261911b21 one more time x2 2025-10-16 18:51:32 -05:00
JMR-dev 62b3dda30b one more time 2025-10-16 18:51:32 -05:00
JMR-dev b84ac5f006 remove pull always 2025-10-16 18:51:32 -05:00
JMR-dev e246f13f88 authenticate with PAT 2025-10-16 18:51:32 -05:00
JMR-dev 8672203541 unbundle windows and linux status checks 2025-10-16 18:51:32 -05:00
JMR-dev 6d32f91273 add auth step to container pull 2025-10-16 18:51:32 -05:00
JMR-dev 994dea669f force workflow to pull fresh image 2025-10-16 18:51:32 -05:00
JMR-dev 5fd9373dc8 updating lock file and Python range for pyinstaller 2025-10-16 18:51:32 -05:00
JMR-dev b5428fc341 changing version specification strategy for requires-python 2025-10-16 18:51:32 -05:00
JMR-dev 3bff70421f changing version specification strategy 2025-10-16 18:51:32 -05:00
JMR-dev d7468df88b release workflow and deps updates 2025-10-16 18:51:32 -05:00
JMR-dev 89473852f6 updated status checks to pull the correct containers and ensured Claude Code review does not run on every push, only new PR's and manually triggered runs 2025-10-16 18:51:32 -05:00
JMR-dev 5396a45a76 added missing container tag' 2025-10-16 18:51:32 -05:00
JMR-dev 3bb9c9c10a updated permissions for workflows 2025-10-16 18:51:32 -05:00
JMR-dev 295ef86475 updated credentials for job steps 2025-10-16 18:51:32 -05:00
JMR-dev 7fcd5108eb * Updated release workflow to test all distros, use pre-built images, and removed redundant env set up steps 
* Updated status checks to mirror release workflow process
* Return type annotations added to build script for better linting/erroring
 2025-10-16 18:51:32 -05:00
JMR-dev 8d7e5a53fd creating reproducible build images 2025-10-16 18:51:32 -05:00
JMR-dev 3f2cba1f04 * Updated workflow 
* Added GPG public signing key
 2025-10-16 18:51:32 -05:00
JMR-dev 6622d40e9e release workflow refinements 2025-10-16 18:51:32 -05:00
JMR-dev 90c29d66d7 Normalize tmp_dir with os.path.normpath() before comparison for Windows compatibility 2025-10-15 15:23:07 -05:00
JMR-dev aed4a1756a address PR feedback 2025-10-15 15:23:07 -05:00
JMR-dev 9ca47d455d PR feedback 2025-10-15 15:23:07 -05:00
JMR-dev 3973ae1801 addressing final PR comments 2025-10-15 15:23:07 -05:00
JMR-dev e2d8b484fc windows compatibility fixes 2025-10-15 15:23:07 -05:00
JMR-dev eaeaaa93f6 address PR feedback 2025-10-15 15:23:07 -05:00
JMR-dev 05e0366363 fixed several security vulnerabilities 2025-10-15 15:23:07 -05:00
JMR-dev 9aec20a061 fix path doubling issue in CI/CD 2025-10-15 15:23:07 -05:00
JMR-dev 83671ae2d8 updated permissions in all Github workflows 2025-10-02 14:37:02 -05:00
JMR-dev 83df7294b4 codeql exclusion for debug tools 2025-10-02 14:07:15 -05:00
JMR-dev f0b57311af updated urllib3 2025-10-02 12:55:09 -05:00
JMR-dev c43609583d bumped pyinstaller version to new major version to eliminate local privilege escalation vuln 2025-10-02 12:30:02 -05:00
JMR-dev 8558f68f8c <fix> Created separate status check file and streamlined release process 2025-10-01 19:55:32 -05:00
JMR-dev 7f41c8dc29 made updates to merge --ff-only instead of rebase on main for safety 2025-10-01 19:23:31 -05:00
JMR-dev b5649d68da updated release workflow to merge develop into main when a release is invoked 2025-10-01 19:23:31 -05:00
JMR-dev 4f1541ead7 update which branches trigger status checks 2025-10-01 18:59:48 -05:00
JMR-dev be037758b5 added permissions to rhel job 2025-10-01 18:59:48 -05:00
JMR-dev 0fdf90b54a updated workflow step 2025-10-01 18:59:48 -05:00
JMR-dev b843040e8b add dockerfile for custom rhel image 2025-10-01 18:59:48 -05:00
JMR-dev f88f379dac fixed quality issues in Github actions workflow 2025-10-01 13:28:39 -05:00
JMR-dev 528444abaa separating sync wiki workflow from release workflow 2025-10-01 13:28:39 -05:00
JMR-dev 59dae6c31a fixing import issues and type annotations. Also fixed broken sync wiki step 2025-10-01 12:57:34 -05:00
JMR-dev 9f0adea09d WIP and add CLAUDE.md 2025-10-01 12:57:34 -05:00
JMR-dev 8920d4b4b3 fixed path issue for local dev packaging builds 2025-09-29 05:16:25 +08:00
JMR-dev 86afecf9ae branch protection config workflow 2025-09-29 05:16:25 +08:00
JMR-dev adc5ecc31b fixes and updates to CI/CD 2025-09-29 05:16:25 +08:00
JMR-dev de78797d5d removed bad spec script 2025-09-29 05:16:25 +08:00
JMR-dev f3cf879dd6 updated spec scripts based on new application structure 2025-09-23 09:05:53 +08:00
JMR-dev f29e39a367 fix path mocking 2025-09-23 08:20:17 +08:00
JMR-dev 06a6876cde updated tests to work with cross platform paths 2025-09-23 08:20:17 +08:00
JMR-dev 96e3d82af4 updated Windows path problem 2025-09-23 08:20:17 +08:00
JMR-dev b7dd3a16c8 added pytest.ini to repo 2025-09-23 08:20:17 +08:00
JMR-dev ec855adc6c updated workflow to run unit tests 2025-09-23 06:40:29 +08:00
JMR-dev 2a9dd04388 added unit test step to release 2025-09-23 06:23:23 +08:00
JMR-dev 4fa7af57dd fixed wiki step to not fail the job since it is still WIP 2025-09-23 06:23:23 +08:00
JMR-dev 27099b8ea2 PR feedback updates 2025-09-23 06:01:53 +08:00
JMR-dev 835c041fc6 modularized test suite to match modular ADB manager 2025-09-23 06:01:53 +08:00
JMR-dev 4e6688bfef removed unused imports/vars 2025-09-23 06:01:53 +08:00
JMR-dev e88aab64d1 added initial test suite and fixed pytest env problems 2025-09-23 06:01:53 +08:00
JMR-dev f8a942bf51 reorganized file and folder structure to reflect responsibilities 2025-09-23 06:01:53 +08:00
JMR-dev 6d08df1807 main window refactor 2025-09-23 06:01:53 +08:00
JMR-dev 21e858dfca WIP progress count for files added and text indicating the file deduplication stage 2025-09-23 06:01:53 +08:00
JMR-dev 33f19f9058 WIP. Deduplication appears to be working. Need better transparency to the user about what stage the transfer is at 2025-09-23 06:01:53 +08:00
JMR-dev 3184516ca4 testing AWS S3 storage workflow 2025-09-08 11:05:12 +08:00
JMR-dev d5621ad3c1 fixing windows artifact upload path 2025-09-08 11:05:12 +08:00
JMR-dev 9f277b2569 fixing formatting in Windows spec file 2025-09-08 11:05:12 +08:00
JMR-dev 40ecb2f24a fixing Windows path in spec file 2025-09-08 11:05:12 +08:00
JMR-dev 4508edc119 fix Windows spec file paths and syntax 2025-09-08 11:05:12 +08:00
JMR-dev 4487e09fef ensure commands run inside container 2025-09-08 11:05:12 +08:00
JMR-dev 7af2c963a4 add env vars to Fedora container 2025-09-08 11:05:12 +08:00
JMR-dev 1b2190921e fix path expansion problem 2025-09-08 11:05:12 +08:00
JMR-dev e190991b3a committing fix for Docker shell scope 2025-09-08 11:05:12 +08:00
JMR-dev cad3e34f68 update Python build deps 2025-09-08 11:05:12 +08:00
JMR-dev ed04051828 update Docker deps and install method 2025-09-08 11:05:12 +08:00
JMR-dev cd014b555d update postinstall script path 2025-09-08 11:05:12 +08:00
JMR-dev 5d087f26e1 change Debian build job to BASH shell 2025-09-08 11:05:12 +08:00
JMR-dev 523d65fbf7 fixing paths and packages for Debian and Arch 2025-09-08 11:05:12 +08:00