Extend ASUS EC detection to other Crosshair VIII models (#511)

* Extend ASUS EC detection to other Crosshair VIII models

Tested to work on my CROSSHAIR VIII Dark Hero.
*Should* also work on the Impact, Formula and Extreme boards since they use the same sensors and thereby most likely the same EC.

Alternatively, an extra case with name.Equals("ROG CROSSHAIR VIII DARK HERO", StringComparison.OrdinalIgnoreCase) could be used instead.

* Add ROG_CROSSHAIR_VIII_DARK_HERO model

* minor formatting

* Update EmbeddedController.cs

Co-authored-by: PhyxionNL <7643972+PhyxionNL@users.noreply.github.com>
This commit is contained in:
ReggX
2021-08-08 13:55:42 +02:00
committed by GitHub
co-authored by PhyxionNL
parent 88761c0921
commit bb83c281f1
4 changed files with 16 additions and 1 deletions
@@ -143,6 +143,8 @@ namespace LibreHardwareMonitor.Hardware.Motherboard
return Model.CROSSHAIR_III_FORMULA;
case var _ when name.Equals("ROG CROSSHAIR VIII HERO", StringComparison.OrdinalIgnoreCase):
return Model.ROG_CROSSHAIR_VIII_HERO;
case var _ when name.Equals("ROG CROSSHAIR VIII DARK HERO", StringComparison.OrdinalIgnoreCase):
return Model.ROG_CROSSHAIR_VIII_DARK_HERO;
case var _ when name.Equals("M2N-SLI DELUXE", StringComparison.OrdinalIgnoreCase):
return Model.M2N_SLI_Deluxe;
case var _ when name.Equals("M4A79XTD EVO", StringComparison.OrdinalIgnoreCase):
@@ -43,6 +43,7 @@ namespace LibreHardwareMonitor.Hardware.Motherboard.Lpc.EC
{
case Model.ROG_STRIX_X570_E_GAMING:
case Model.ROG_CROSSHAIR_VIII_HERO:
case Model.ROG_CROSSHAIR_VIII_DARK_HERO:
{
sources.AddRange(new EmbeddedControllerSource[]
{
@@ -52,7 +53,6 @@ namespace LibreHardwareMonitor.Hardware.Motherboard.Lpc.EC
new("T Sensor", 0x3D, SensorType.Temperature, ReadByte),
new("VRM", 0x3E, SensorType.Temperature, ReadByte),
new("CPU Opt", 0xB0, SensorType.Fan, ReadWordBE),
new("Chipset", 0xB4, SensorType.Fan, ReadWordBE),
new("CPU", 0xF4, SensorType.Current, ReadByte)
});
@@ -62,7 +62,18 @@ namespace LibreHardwareMonitor.Hardware.Motherboard.Lpc.EC
switch (model)
{
case Model.ROG_STRIX_X570_E_GAMING:
case Model.ROG_CROSSHAIR_VIII_HERO:
{
sources.Add(new EmbeddedControllerSource("Chipset", 0xB4, SensorType.Fan, ReadWordBE));
break;
}
}
switch (model)
{
case Model.ROG_CROSSHAIR_VIII_HERO:
case Model.ROG_CROSSHAIR_VIII_DARK_HERO:
{
// TODO: "why 42?" is a silly question, I know, but still, why? On the serious side, it might be 41.6(6)
sources.Add(new EmbeddedControllerSource("Flow Rate", 0xBC, SensorType.Flow, (ecIO, port) => ecIO.ReadWordBE(port) / 42f * 60f));
@@ -38,6 +38,7 @@ namespace LibreHardwareMonitor.Hardware.Motherboard
// ASUS
CROSSHAIR_III_FORMULA,
ROG_CROSSHAIR_VIII_HERO,
ROG_CROSSHAIR_VIII_DARK_HERO,
ROG_STRIX_X470_I,
ROG_STRIX_X570_E_GAMING,
M2N_SLI_Deluxe,
@@ -2314,6 +2314,7 @@ namespace LibreHardwareMonitor.Hardware.Motherboard
break;
}
case Model.ROG_CROSSHAIR_VIII_HERO: // NCT6798D
case Model.ROG_CROSSHAIR_VIII_DARK_HERO: // NCT6798D
{
v.Add(new Voltage("Vcore", 0));
v.Add(new Voltage("Voltage #2", 1, true));