Cleanup warnings (#94)

* (CS3005) Remove unused duplicate property differing only in case

* (CS3001, CS3003, CS3005) Make OpenHardwareMonitorLib not CLS compliant

* (NU5125) licenseUrl will be deprecated

* (CS0618) SecurityAction.RequestMinimum is obsolete

* "Migrated rules for Aga.Controls.ruleset" is missing

External/Aga.Controls/Aga.Controls.csproj

@@ -55,7 +55,7 @@
     <CodeAnalysisRules>
     </CodeAnalysisRules>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-    <CodeAnalysisRuleSet>Migrated rules for Aga.Controls.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">

External/Aga.Controls/Properties/AssemblyInfo.cs

@@ -6,7 +6,6 @@ using System.Security.Permissions;
 
 [assembly: ComVisible(false)]
 [assembly: CLSCompliant(false)]
-[assembly: SecurityPermission(SecurityAction.RequestMinimum, Execution = true)]
 
 [assembly: AssemblyTitle("Aga.Controls")]
 [assembly: AssemblyCopyright("Copyright © Andrey Gliznetsov 2006 - 2009")]

Hardware/HDD/SmartNames.cs

@@ -163,10 +163,6 @@ namespace OpenHardwareMonitor.Hardware.HDD {
       get { return "Load/Unload Retry Count"; }
     }
 
-    public static string MediaWearoutIndicator {
-      get { return "Media Wearout Indicator"; }
-    }
-
     public static string MultiZoneErrorRate {
       get { return "Multi-Zone Error Rate"; }
     }

OpenHardwareMonitorLib.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>net452;netstandard2.0</TargetFrameworks>
@@ -14,12 +14,16 @@
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <Authors>Libre Hardware Monitor contributors, Michael Möller</Authors>
     <PackageId>LibreHardwareMonitorLib</PackageId>
-    <PackageLicenseUrl>https://github.com/LibreHardwareMonitor/LibreHardwareMonitor</PackageLicenseUrl>
+    <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <PackageProjectUrl>https://github.com/LibreHardwareMonitor/LibreHardwareMonitor</PackageProjectUrl>
     <PackageTags>libre open hardware monitor monitoring system logging cpu gpu</PackageTags>
     <RepositoryUrl>https://github.com/LibreHardwareMonitor/LibreHardwareMonitor</RepositoryUrl>
   </PropertyGroup>
 
+  <ItemGroup>
+    <None Include="LICENSE" Pack="true" Visible="false" PackagePath=""/>
+  </ItemGroup>
+
   <ItemGroup Condition=" '$(TargetFramework)' == 'net452' ">
     <Reference Include="System" />
     <Reference Include="System.Management" />

Properties/AssemblyLibInfo.cs

@@ -23,6 +23,5 @@ using System.Runtime.InteropServices;
 [assembly: AssemblyCulture("")]
 
 [assembly: ComVisible(false)]
-[assembly: CLSCompliant(true)]