Extract IHardwareMonitorService, ILogger, IRemoteWebServer interfaces

Define interfaces over the three domain services that the view model hard-news
today (the testability blocker). Concrete types implement the new interfaces;
no wiring or behavior change yet.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
2026-06-02 15:00:30 -05:00
co-authored by Copilot
parent 9b576ea633
commit 50a07d5ce9
6 changed files with 114 additions and 3 deletions
@@ -12,7 +12,7 @@ using LibreHardwareMonitor.Windows.WinUI.ViewModels;
namespace LibreHardwareMonitor.Windows.WinUI.Services;
public sealed class HardwareMonitorService : IDisposable
public sealed class HardwareMonitorService : IHardwareMonitorService
{
private const string DeferDimmDetectionSetting = "memory.deferDimmDetection";
private const string DeferCpuInitialUpdateSetting = "cpu.deferInitialUpdate";
@@ -0,0 +1,58 @@
// This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
// If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
// Copyright (C) LibreHardwareMonitor and Contributors.
using System;
using System.Threading;
using System.Threading.Tasks;
using LibreHardwareMonitor.Hardware;
using LibreHardwareMonitor.Windows.WinUI.ViewModels;
namespace LibreHardwareMonitor.Windows.WinUI.Services;
/// <summary>
/// Owns the <see cref="Hardware.Computer" /> lifecycle and the sensor tree, exposing the surface the
/// view model needs. Extracted as an interface so the view model can be unit-tested with a fake.
/// </summary>
public interface IHardwareMonitorService : IDisposable
{
event EventHandler? TreeRebuilt;
Computer Computer { get; }
object SensorReadLock { get; }
SensorTreeItemViewModel Root { get; }
bool IsMotherboardEnabled { get; set; }
bool IsCpuEnabled { get; set; }
bool IsMemoryEnabled { get; set; }
bool IsGpuEnabled { get; set; }
bool IsPowerMonitorEnabled { get; set; }
bool IsControllerEnabled { get; set; }
bool IsStorageEnabled { get; set; }
bool IsNetworkEnabled { get; set; }
bool IsPsuEnabled { get; set; }
bool IsBatteryEnabled { get; set; }
bool ForceDriveWakeup { get; set; }
Task OpenAsync(bool raiseTreeRebuilt = true, CancellationToken cancellationToken = default);
void Reset();
Task UpdateAsync();
void ResetMinMax();
void ClearSensorValues();
}
@@ -0,0 +1,19 @@
// This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
// If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
// Copyright (C) LibreHardwareMonitor and Contributors.
using System;
namespace LibreHardwareMonitor.Windows.WinUI.Services;
/// <summary>
/// CSV sensor logger. Extracted as an interface so the view model can be unit-tested with a fake.
/// </summary>
public interface ILogger
{
LoggerFileRotation FileRotationMethod { get; set; }
TimeSpan LoggingInterval { get; set; }
void Log();
}
@@ -0,0 +1,34 @@
// This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
// If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
// Copyright (C) LibreHardwareMonitor and Contributors.
using System;
namespace LibreHardwareMonitor.Windows.WinUI.Services;
/// <summary>
/// Optional HTTP server exposing sensor data. Extracted as an interface so the view model can be
/// unit-tested with a fake (and so the real server's network resources stay out of tests).
/// </summary>
public interface IRemoteWebServer : IDisposable
{
bool AuthEnabled { get; set; }
string ListenerIp { get; set; }
int ListenerPort { get; set; }
string PasswordHash { get; }
bool PlatformNotSupported { get; }
string UserName { get; set; }
void SetPassword(string plainPassword);
bool Start();
bool Stop();
void Quit();
}
@@ -11,7 +11,7 @@ using LibreHardwareMonitor.Hardware;
namespace LibreHardwareMonitor.Windows.WinUI.Services;
public sealed class Logger
public sealed class Logger : ILogger
{
private const string FileNameFormat = "LibreHardwareMonitorLog-{0:yyyy-MM-dd}{1}.csv";
@@ -22,7 +22,7 @@ using LibreHardwareMonitor.Windows.WinUI.ViewModels;
namespace LibreHardwareMonitor.Windows.WinUI.Services;
public sealed class RemoteWebServer : IDisposable
public sealed class RemoteWebServer : IRemoteWebServer
{
private readonly IComputer _computer;
private readonly object _sensorReadLock;