LibreMediaConverter

JMR-dev/LibreMediaConverter

Fork 0

...

Author	SHA1	Message	Date
Jason Ross	bf8b438b45	Merge pull request #145 from JMR-dev/test/readspec-enum-fallbacks C1: pin readSpec's three enum fallbacks	2026-08-27 08:55:01 -05:00
JMR-devandClaude Opus 5	3a5210ec5d	S2 + S3 (#142 , #143 ): the two OutputPublisher seams, and where the second one goes #142 -- openOutputStream refuses two ways and only one was reachable. A provider that has gone away throws from inside the call, which `a destination the provider will not open...` already drives. A provider that is present and declines returns null, and nothing could produce that on demand. openDestination is the seam; the test asserts the failure names the destination, which is what separates the `?: error(...)` from an NPE inside `use`. #143 -- the sweep's re-read. The seam the ticket proposed does not reach it. Overriding the listing fires before the entries are snapshotted, so StagingSweep.collectable is handed the new timestamp, the file is never proposed for deletion, and the guard is never exercised. Measured: with an entriesIn seam, deleting the guard outright left the test green. The race is a file that was collectable when the snapshot was taken and is not by the time the delete comes round, so the seam has to sit at the snapshot. `snapshot(listing)` does, and deleting the guard now reddens the test. Three mutations after the move, three red: null stream returns silently null-return test null stream via !! instead null-return test sweep deletes unconditionally race test OutputPublisher.kt now has no never-executed lines at all. Two partial branches are left and both are named exemptions rather than gaps: L216's `getOrNull() ?: false` and L304's `getOrDefault(absoluteFile)` are the failure arms of a runCatching whose body cannot be made to throw through any public entry point -- the same shape as the `size >= 0` exemption recorded in the previous commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-27 07:22:38 -05:00
Jason Ross	5f3eda9c40	Merge pull request #149 from JMR-dev/test/outputpublisher-partial-branches C6: OutputPublisher's guarded branches, three of them guarding a delete	2026-08-27 07:22:35 -05:00

Author

SHA1

Message

Date

Jason Ross

bf8b438b45

Merge pull request #145 from JMR-dev/test/readspec-enum-fallbacks

C1: pin readSpec's three enum fallbacks

2026-08-27 08:55:01 -05:00

JMR-devandClaude Opus 5

3a5210ec5d

S2 + S3 (#142 , #143 ): the two OutputPublisher seams, and where the second one goes

#142 -- openOutputStream refuses two ways and only one was reachable. A
provider that has gone away throws from inside the call, which
`a destination the provider will not open...` already drives. A provider
that is present and declines returns null, and nothing could produce that
on demand. openDestination is the seam; the test asserts the failure names
the destination, which is what separates the `?: error(...)` from an NPE
inside `use`.

#143 -- the sweep's re-read. **The seam the ticket proposed does not reach
it.** Overriding the listing fires before the entries are snapshotted, so
StagingSweep.collectable is handed the new timestamp, the file is never
proposed for deletion, and the guard is never exercised. Measured: with an
entriesIn seam, deleting the guard outright left the test green.

The race is a file that *was* collectable when the snapshot was taken and
is not by the time the delete comes round, so the seam has to sit at the
snapshot. `snapshot(listing)` does, and deleting the guard now reddens the
test.

Three mutations after the move, three red:

  null stream returns silently   null-return test
  null stream via !! instead     null-return test
  sweep deletes unconditionally  race test

OutputPublisher.kt now has no never-executed lines at all. Two partial
branches are left and both are named exemptions rather than gaps:
L216's `getOrNull() ?: false` and L304's `getOrDefault(absoluteFile)` are
the failure arms of a runCatching whose body cannot be made to throw
through any public entry point -- the same shape as the `size >= 0`
exemption recorded in the previous commit.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-27 07:22:38 -05:00

Jason Ross

5f3eda9c40

Merge pull request #149 from JMR-dev/test/outputpublisher-partial-branches

C6: OutputPublisher's guarded branches, three of them guarding a delete

2026-08-27 07:22:35 -05:00

Compare commits

Diff Content Not Available