feat(settings): reorder the Advanced settings section #178

Merged
JMR-dev merged 6 commits from feat-162-advanced-settings-hierarchy into main 2026-07-03 01:07:42 +00:00
JMR-dev commented 2026-07-02 22:47:18 +00:00 (Migrated from github.com)

Summary

  • Reorder the collapsible Advanced section's SwitchRows in SettingsScreen.kt to the order specified in #162: Push Mail, Load Remote Images by Default, Encrypt Local Cache, Require Screen Lock, then Allow insecure STARTTLS fallback (moved last).
  • Relocate the Background battery usage ClickRow out of Advanced entirely and into the main (always-visible) settings list, directly above local retention ("Storage on this device") — it's common enough (OEM battery optimization delaying push mail) that it shouldn't be hidden behind "Advanced".
  • Pure composable-placement change: no string changes (existing wording already matched), no behavior change to any individual toggle/row.

Coordinates with #158/#169 (already merged), which reordered the surrounding top-level sections that the relocated Battery row now sits among.

Closes #162

Test plan

  • assembleDebug, testDebugUnitTest, lintDebug, ktlintCheck, detekt, compileDebugAndroidTestKotlin all green locally (JDK 21).
  • Reviewed SettingsScreenTest.kt (androidTest): its app-lock test clicks the Advanced header then the row by text, not position — unaffected by reorder. No order-dependent tests found for the Advanced block or the Battery row.

🤖 Generated with Claude Code

## Summary - Reorder the collapsible **Advanced** section's `SwitchRow`s in `SettingsScreen.kt` to the order specified in #162: Push Mail, Load Remote Images by Default, Encrypt Local Cache, Require Screen Lock, then Allow insecure STARTTLS fallback (moved last). - Relocate the **Background battery usage** `ClickRow` out of Advanced entirely and into the main (always-visible) settings list, directly above local retention ("Storage on this device") — it's common enough (OEM battery optimization delaying push mail) that it shouldn't be hidden behind "Advanced". - Pure composable-placement change: no string changes (existing wording already matched), no behavior change to any individual toggle/row. Coordinates with #158/#169 (already merged), which reordered the surrounding top-level sections that the relocated Battery row now sits among. Closes #162 ## Test plan - [x] `assembleDebug`, `testDebugUnitTest`, `lintDebug`, `ktlintCheck`, `detekt`, `compileDebugAndroidTestKotlin` all green locally (JDK 21). - [x] Reviewed `SettingsScreenTest.kt` (androidTest): its app-lock test clicks the Advanced header then the row by text, not position — unaffected by reorder. No order-dependent tests found for the Advanced block or the Battery row. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.