fix(accountsetup): show 2-Step Verification link before app-password link for Gmail #166

Merged
JMR-dev merged 4 commits from fix-152-gmail-2fa-button-order into main 2026-07-02 22:42:37 +00:00
JMR-dev commented 2026-07-02 21:39:18 +00:00 (Migrated from github.com)

Summary

  • Swaps the order of the two OutlinedButtons on the Gmail guided app-password setup screen: the "How to turn on 2-Step Verification" button (twoFactorHelpUrl) now renders before the "Create an app password for Gmail" button (appPasswordHelpUrl), since 2-Step Verification is a prerequisite for the app-passwords page.
  • Updates the explanatory comment above the button block to reflect the new ordering.
  • No visible change for Yahoo/iCloud, which have no twoFactorHelpUrl.

Closes #152

Test plan

  • Local gate (JDK 21): assembleDebug, testDebugUnitTest, lintDebug, ktlintCheck, detekt, compileDebugAndroidTestKotlin — all green.
  • Reviewed existing OnboardingFlowTest (androidTest) assertions for these buttons — they check text presence/visibility, not order, so they remain valid (not run locally per repo convention; CI runs E2E).

🤖 Generated with Claude Code

## Summary - Swaps the order of the two `OutlinedButton`s on the Gmail guided app-password setup screen: the "How to turn on 2-Step Verification" button (`twoFactorHelpUrl`) now renders before the "Create an app password for Gmail" button (`appPasswordHelpUrl`), since 2-Step Verification is a prerequisite for the app-passwords page. - Updates the explanatory comment above the button block to reflect the new ordering. - No visible change for Yahoo/iCloud, which have no `twoFactorHelpUrl`. Closes #152 ## Test plan - [x] Local gate (JDK 21): `assembleDebug`, `testDebugUnitTest`, `lintDebug`, `ktlintCheck`, `detekt`, `compileDebugAndroidTestKotlin` — all green. - [x] Reviewed existing `OnboardingFlowTest` (androidTest) assertions for these buttons — they check text presence/visibility, not order, so they remain valid (not run locally per repo convention; CI runs E2E). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.