Origin: code review of PR #54. Reuse/maintainability — the divergence is already observable.
Problem
SPECIAL_USE_ATTRIBUTES (Folder.kt:60) is a second hand-maintained RFC 6154 attribute table sitting six lines below roleOf()'s attribute when-ladder (Folder.kt:45-49) in the same companion object. They already disagree: \all and \flagged are in the set but have no roleOf branch. Every future attribute change must now be made twice, or role classification and label de-duplication diverge.
The disagreement is live on one folder today: Mappers.kt:160-163 feeds the same attributes list to both functions, so a non-English Gmail account's All Mail (e.g. German "Alle Nachrichten", advertising \All) gets specialUse = true from isServerSpecial() yet role = NORMAL from roleOf() (no \all branch, and the English-only "all mail" display-name fallback misses) — treated as provider-special for label de-dup while sorting among user folders with no role icon. The roleOf gap itself predates PR #54; what #54 added is the second table that locks the drift in.
Suggested fix
One ordered Map<String, FolderRole?> in the companion (role-less entries like \flagged map to null):
roleOf = first non-null role among the folder's attributes (preserves the ladder's precedence),
isServerSpecial = any attribute is a key.
This also absorbs #62 (\Important becomes one more entry) and fixes the KDoc nit that \All is a standard RFC 6154 attribute, not a Gmail extension. Consider a \all → ARCHIVE mapping while here, which fixes the localized All-Mail role for free.
Origin: code review of PR #54. Reuse/maintainability — the divergence is already observable.
## Problem
`SPECIAL_USE_ATTRIBUTES` (`Folder.kt:60`) is a second hand-maintained RFC 6154 attribute table sitting six lines below `roleOf()`'s attribute when-ladder (`Folder.kt:45-49`) in the same companion object. They already disagree: `\all` and `\flagged` are in the set but have no `roleOf` branch. Every future attribute change must now be made twice, or role classification and label de-duplication diverge.
The disagreement is live on one folder today: `Mappers.kt:160-163` feeds the same attributes list to both functions, so a non-English Gmail account's All Mail (e.g. German "Alle Nachrichten", advertising `\All`) gets `specialUse = true` from `isServerSpecial()` yet `role = NORMAL` from `roleOf()` (no `\all` branch, and the English-only "all mail" display-name fallback misses) — treated as provider-special for label de-dup while sorting among user folders with no role icon. The `roleOf` gap itself predates PR #54; what #54 added is the second table that locks the drift in.
## Suggested fix
One ordered `Map<String, FolderRole?>` in the companion (role-less entries like `\flagged` map to null):
- `roleOf` = first non-null role among the folder's attributes (preserves the ladder's precedence),
- `isServerSpecial` = any attribute is a key.
This also absorbs #62 (`\Important` becomes one more entry) and fixes the KDoc nit that `\All` is a standard RFC 6154 attribute, not a Gmail extension. Consider a `\all → ARCHIVE` mapping while here, which fixes the localized All-Mail role for free.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Origin: code review of PR #54. Reuse/maintainability — the divergence is already observable.
Problem
SPECIAL_USE_ATTRIBUTES(Folder.kt:60) is a second hand-maintained RFC 6154 attribute table sitting six lines belowroleOf()'s attribute when-ladder (Folder.kt:45-49) in the same companion object. They already disagree:\alland\flaggedare in the set but have noroleOfbranch. Every future attribute change must now be made twice, or role classification and label de-duplication diverge.The disagreement is live on one folder today:
Mappers.kt:160-163feeds the same attributes list to both functions, so a non-English Gmail account's All Mail (e.g. German "Alle Nachrichten", advertising\All) getsspecialUse = truefromisServerSpecial()yetrole = NORMALfromroleOf()(no\allbranch, and the English-only "all mail" display-name fallback misses) — treated as provider-special for label de-dup while sorting among user folders with no role icon. TheroleOfgap itself predates PR #54; what #54 added is the second table that locks the drift in.Suggested fix
One ordered
Map<String, FolderRole?>in the companion (role-less entries like\flaggedmap to null):roleOf= first non-null role among the folder's attributes (preserves the ladder's precedence),isServerSpecial= any attribute is a key.This also absorbs #62 (
\Importantbecomes one more entry) and fixes the KDoc nit that\Allis a standard RFC 6154 attribute, not a Gmail extension. Consider a\all → ARCHIVEmapping while here, which fixes the localized All-Mail role for free.