SPECIAL_USE_ATTRIBUTES (Folder.kt:60) omits \Important (RFC 8457), which Gmail always advertises on [Gmail]/Important in LIST responses (per Google's IMAP extensions docs: * LIST (\HasNoChildren \Important) "/" "[Gmail]/Important"). So isServerSpecial() returns false and the de-dup pass treats the provider's built-in Important folder as user-created.
Failure scenario
Gmail account with the Important label visible over IMAP (the default) plus any folder whose leaf is "Important" — realistically a nested label like Work/Important, since Gmail reserves the bare name. Both base-label to "Important"; [Gmail]/Important gets the parent-parenthesis form "Important ([Gmail])" — leaking the raw namespace container into the UI — next to "Important (Work)", inconsistent with every other Gmail built-in ([Gmail]/Starred via \Flagged renders "Starred - Gmail").
Suggested fix
Add "\\important" to SPECIAL_USE_ATTRIBUTES + a FolderRoleTest case. (Longer-term, the set should derive from a single attribute table — tracked separately.)
Origin: code review of PR #54 (drawer folder de-duplication). One-token fix.
## Problem
`SPECIAL_USE_ATTRIBUTES` (`Folder.kt:60`) omits `\Important` (RFC 8457), which Gmail always advertises on `[Gmail]/Important` in LIST responses (per Google's IMAP extensions docs: `* LIST (\HasNoChildren \Important) "/" "[Gmail]/Important"`). So `isServerSpecial()` returns false and the de-dup pass treats the provider's built-in Important folder as user-created.
## Failure scenario
Gmail account with the Important label visible over IMAP (the default) plus any folder whose leaf is "Important" — realistically a nested label like `Work/Important`, since Gmail reserves the bare name. Both base-label to "Important"; `[Gmail]/Important` gets the parent-parenthesis form **"Important ([Gmail])"** — leaking the raw namespace container into the UI — next to "Important (Work)", inconsistent with every other Gmail built-in (`[Gmail]/Starred` via `\Flagged` renders "Starred - Gmail").
## Suggested fix
Add `"\\important"` to `SPECIAL_USE_ATTRIBUTES` + a `FolderRoleTest` case. (Longer-term, the set should derive from a single attribute table — tracked separately.)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Origin: code review of PR #54 (drawer folder de-duplication). One-token fix.
Problem
SPECIAL_USE_ATTRIBUTES(Folder.kt:60) omits\Important(RFC 8457), which Gmail always advertises on[Gmail]/Importantin LIST responses (per Google's IMAP extensions docs:* LIST (\HasNoChildren \Important) "/" "[Gmail]/Important"). SoisServerSpecial()returns false and the de-dup pass treats the provider's built-in Important folder as user-created.Failure scenario
Gmail account with the Important label visible over IMAP (the default) plus any folder whose leaf is "Important" — realistically a nested label like
Work/Important, since Gmail reserves the bare name. Both base-label to "Important";[Gmail]/Importantgets the parent-parenthesis form "Important ([Gmail])" — leaking the raw namespace container into the UI — next to "Important (Work)", inconsistent with every other Gmail built-in ([Gmail]/Starredvia\Flaggedrenders "Starred - Gmail").Suggested fix
Add
"\\important"toSPECIAL_USE_ATTRIBUTES+ aFolderRoleTestcase. (Longer-term, the set should derive from a single attribute table — tracked separately.)