JMR-dev/LibreMail
1
0
Fork 0
Code Issues 40 Pull Requests 2 Actions Packages Projects Releases 2 Wiki Activity

fix(test): stub the new insertAtEnd DAO call in AccountRepositoryImplTest

Browse Source 
The #164 reorder-accounts feature switched addImapAccount/addOutlookAccount from accountDao.upsert(...) to accountDao.insertAtEnd(...) (a @Transaction default method that stamps sortOrder before delegating to upsert), but the test's mocks/verifies still targeted upsert directly. Since MockK doesn't invoke a mocked interface's default method body, the unstubbed insertAtEnd call threw MockKException. Updated the stub/verify pairs in both add-account happy-path tests and the exactly-0 verifies in both failure-path tests to reference insertAtEnd.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
JMR-dev
2026-07-03 18:45:45 -05:00
co-authored by Claude Opus 4.8
parent 5705e0e7f8
commit 53f600369b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/test/kotlin/org/libremail/data/repository/AccountRepositoryImplTest.kt
+5 -5
View File
@@ -105,7 +105,7 @@ class AccountRepositoryImplTest {
coEvery { imapClient.listFolders(capture(used)) } returns listOf(
FetchedFolder("INBOX", "INBOX", emptyList(), selectable = true),
)
coEvery { accountDao.upsert(any()) } just Runs
coEvery { accountDao.insertAtEnd(any()) } just Runs
val result = repository.addImapAccount(account, "app-password")
@@ -114,7 +114,7 @@ class AccountRepositoryImplTest {
assertFalse(used.captured.useXoauth2)
assertEquals("app-password", used.captured.secret)
assertEquals("ada@example.org", used.captured.username)
coVerify { accountDao.upsert(any()) }
coVerify { accountDao.insertAtEnd(any()) }
coVerify { accountSettingsRepository.ensureDefaults(account.id) }
coVerify { credentialStore.saveSecret(account.id, "app-password") }
verify { mailNotifier.ensureAccountChannel(account) }
@@ -129,7 +129,7 @@ class AccountRepositoryImplTest {
val result = repository.addImapAccount(account(), "wrong")
assertTrue(result.isFailure)
coVerify(exactly = 0) { accountDao.upsert(any()) }
coVerify(exactly = 0) { accountDao.insertAtEnd(any()) }
coVerify(exactly = 0) { credentialStore.saveSecret(any(), any()) }
verify(exactly = 0) { syncScheduler.syncNow() }
}
@@ -141,7 +141,7 @@ class AccountRepositoryImplTest {
FetchedFolder("INBOX", "INBOX", emptyList(), selectable = true),
)
val saved = slot<AccountEntity>()
coEvery { accountDao.upsert(capture(saved)) } just Runs
coEvery { accountDao.insertAtEnd(capture(saved)) } just Runs
val result = repository.addOutlookAccount("me@outlook.com", "access-token", "{authstate}")
@@ -164,7 +164,7 @@ class AccountRepositoryImplTest {
val result = repository.addOutlookAccount("me@outlook.com", "expired", "{authstate}")
assertTrue(result.isFailure)
coVerify(exactly = 0) { accountDao.upsert(any()) }
coVerify(exactly = 0) { accountDao.insertAtEnd(any()) }
coVerify(exactly = 0) { credentialStore.saveSecret(any(), any()) }
}