JMR-devandClaude Opus 4.8
bd7fe21d97
Implement the storage path: for each accepted report, scrub PII (#8), encrypt with AES-256-GCM (ADR #5), and write only ciphertext to R2, wired in as the real ingest Sink replacing NopSink. - internal/crypto: AES-256-GCM in the exact ADR #5 wire format (magic "LMB1" || version || key_id BE16 || nonce(12) || ct || tag(16); the 7-byte header is the GCM AAD). Provider-independent framing shared by a host crypto/aes+crypto/cipher impl (tests, devserver) and a Wasm SubtleCrypto impl (syscall/js, //go:build js && wasm) per the TinyGo constraint; both produce byte-identical frames. Versioned keyring with key_id rotation; ParseKeyring reads the Secrets Store JSON secret. - internal/storage: ObjectStore interface with an in-memory fake (tests, devserver) and a Wasm R2Store (syumai/workers R2 binding). Sink ties scrub -> Seal -> Put under a unique reports/<ts>-<rand> key. WorkerSink loads the keyring from Secrets Store (BUGREPORT_ENC_KEYRING), cached for the isolate lifetime. - handler.New now takes an injectable ingest.Sink; the Worker uses the real R2/Secrets-Store sink, the devserver a memory + throwaway-key sink. - wrangler.jsonc: add REPORTS_BUCKET (R2) and BUGREPORT_ENC_KEYRING (Secrets Store) bindings. Tests (host, no TinyGo): encrypt/decrypt roundtrip; ciphertext != plaintext; wrong key + tamper (ct/tag/nonce/header-AAD) fail; exact wire layout plus a known-answer vector; key_id rotation with retained keys; full sink path (PII scrubbed then encrypted, readback requires the key and yields the scrubbed content). Existing ingest/handler behavior preserved (202 on valid POST). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
109 lines
3.2 KiB
Go
109 lines
3.2 KiB
Go
package handler
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/JMR-dev/LibreMail-Bug-Report-Ingest/internal/ingest"
|
|
)
|
|
|
|
// doRequest runs a single request through the handler and returns the recorder.
|
|
func doRequest(t *testing.T, method, target string) *httptest.ResponseRecorder {
|
|
t.Helper()
|
|
req := httptest.NewRequest(method, target, nil)
|
|
rec := httptest.NewRecorder()
|
|
New(nil).ServeHTTP(rec, req)
|
|
return rec
|
|
}
|
|
|
|
// decode parses the JSON response body or fails the test.
|
|
func decode(t *testing.T, rec *httptest.ResponseRecorder) response {
|
|
t.Helper()
|
|
var got response
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
|
|
t.Fatalf("response body is not valid JSON: %v (body=%q)", err, rec.Body.String())
|
|
}
|
|
return got
|
|
}
|
|
|
|
func TestRoot(t *testing.T) {
|
|
rec := doRequest(t, http.MethodGet, "/")
|
|
|
|
if rec.Code != http.StatusOK {
|
|
t.Fatalf("GET / status = %d, want %d", rec.Code, http.StatusOK)
|
|
}
|
|
if ct := rec.Header().Get("Content-Type"); ct != "application/json; charset=utf-8" {
|
|
t.Errorf("GET / Content-Type = %q, want application/json; charset=utf-8", ct)
|
|
}
|
|
got := decode(t, rec)
|
|
if got.Status != "ok" {
|
|
t.Errorf("GET / status field = %q, want ok", got.Status)
|
|
}
|
|
if got.Service != serviceName {
|
|
t.Errorf("GET / service field = %q, want %q", got.Service, serviceName)
|
|
}
|
|
if got.Message == "" {
|
|
t.Error("GET / message field is empty, want a hello message")
|
|
}
|
|
}
|
|
|
|
func TestHealthz(t *testing.T) {
|
|
rec := doRequest(t, http.MethodGet, "/healthz")
|
|
|
|
if rec.Code != http.StatusOK {
|
|
t.Fatalf("GET /healthz status = %d, want %d", rec.Code, http.StatusOK)
|
|
}
|
|
got := decode(t, rec)
|
|
if got.Status != "ok" {
|
|
t.Errorf("GET /healthz status field = %q, want ok", got.Status)
|
|
}
|
|
}
|
|
|
|
func TestUnknownPathReturns404(t *testing.T) {
|
|
rec := doRequest(t, http.MethodGet, "/does-not-exist")
|
|
|
|
if rec.Code != http.StatusNotFound {
|
|
t.Fatalf("GET /does-not-exist status = %d, want %d", rec.Code, http.StatusNotFound)
|
|
}
|
|
got := decode(t, rec)
|
|
if got.Status != "error" {
|
|
t.Errorf("404 status field = %q, want error", got.Status)
|
|
}
|
|
}
|
|
|
|
// TestReportsRoutedToInjectedSink proves New wires the injected sink into
|
|
// POST /v1/reports (the #9 storage seam), returning 202 and storing the report.
|
|
func TestReportsRoutedToInjectedSink(t *testing.T) {
|
|
sink := &ingest.MemorySink{}
|
|
h := New(sink)
|
|
|
|
body := `{"appVersion":"1.0.0","platform":"android","report":"boom"}`
|
|
req := httptest.NewRequest(http.MethodPost, "/v1/reports", strings.NewReader(body))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
rec := httptest.NewRecorder()
|
|
h.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusAccepted {
|
|
t.Fatalf("POST /v1/reports status = %d, want %d", rec.Code, http.StatusAccepted)
|
|
}
|
|
if sink.Len() != 1 {
|
|
t.Fatalf("injected sink stored %d reports, want 1", sink.Len())
|
|
}
|
|
}
|
|
|
|
func TestNonGetReturns405(t *testing.T) {
|
|
for _, path := range []string{"/", "/healthz"} {
|
|
rec := doRequest(t, http.MethodPost, path)
|
|
|
|
if rec.Code != http.StatusMethodNotAllowed {
|
|
t.Errorf("POST %s status = %d, want %d", path, rec.Code, http.StatusMethodNotAllowed)
|
|
}
|
|
if allow := rec.Header().Get("Allow"); allow != http.MethodGet {
|
|
t.Errorf("POST %s Allow header = %q, want GET", path, allow)
|
|
}
|
|
}
|
|
}
|