From cc9b897368e6992a9ca0003f844776b0439b8940 Mon Sep 17 00:00:00 2001 From: MoshiMoshi0 <902882+MoshiMoshi0@users.noreply.github.com> Date: Thu, 4 Sep 2025 20:14:32 +0200 Subject: [PATCH] Fix possible collection was modified exception (#1836) --- LibreHardwareMonitorLib/Hardware/Memory/MemoryGroup.cs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/LibreHardwareMonitorLib/Hardware/Memory/MemoryGroup.cs b/LibreHardwareMonitorLib/Hardware/Memory/MemoryGroup.cs index 51c1a58..b9d5b4a 100644 --- a/LibreHardwareMonitorLib/Hardware/Memory/MemoryGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Memory/MemoryGroup.cs @@ -176,6 +176,8 @@ internal class MemoryGroup : IGroup, IHardwareChanged private void AddDimms(List accessors, ISettings settings) { + List additions = []; + foreach (SPDAccessor ram in accessors) { //Default value @@ -186,9 +188,11 @@ internal class MemoryGroup : IGroup, IHardwareChanged name = $"{ram.GetModuleManufacturerString()} - {ram.ModulePartNumber()} (#{ram.Index})"; DimmMemory memory = new(ram, name, new Identifier($"memory/dimm/{ram.Index}"), settings); - - _hardware.Add(memory); - HardwareAdded?.Invoke(memory); + additions.Add(memory); } + + _hardware = [.. _hardware, .. additions]; + foreach (Hardware hardware in additions) + HardwareAdded?.Invoke(hardware); } }