JMR-dev/ReLibreHardwareMonitor
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix unbounded memory growth during monitoring

Browse Source 
While the app was running, working set grew ~20 MB/min (reaching tens of GB
over a day). dotnet-gcdump traced it to COM-callable wrappers accumulating from
the per-tick binding interop: SensorTreeItemViewModel.RefreshValues raised
PropertyChanged for Value/Min/Max/ToolTip on every sensor every update tick, and
ViewModelBase allocated a new PropertyChangedEventArgs per raise. WinUI's binding
engine is native, so each raised event marshals its args across the boundary and
retains a wrapper.

- ViewModelBase: reuse one cached PropertyChangedEventArgs per property name.
- SensorTreeItemViewModel.RefreshValues: raise PropertyChanged only when the
  formatted text actually changed.

Also close a leaked D3DKMT adapter handle: D3DDisplayDevice.GetDeviceInfoByIdentifier
opened the adapter but skipped CloseAdapter on every early-return failure path,
and it runs on each GPU's Update() tick. Close it in a finally block.

Verified with dotnet-gcdump over an 18-minute soak: managed heap and live object
count stay flat (~50 MB) instead of climbing 47 -> 470 MB.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
JMR-dev
2026-06-01 16:16:40 -05:00
co-authored by Claude Opus 4.8
parent 041e21f9a6
commit 1bde5d531d
3 changed files with 119 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
LibreHardwareMonitor.Windows.WinUI/ViewModels/SensorTreeItemViewModel.cs
+36 -4
View File
@@ -30,6 +30,10 @@ public sealed class SensorTreeItemViewModel : ViewModelBase
private Visibility _valueColumnVisibility = Visibility.Visible;
private Color? _penColor;
private TemperatureUnit _temperatureUnit;
private string? _lastValue;
private string? _lastMin;
private string? _lastMax;
private string? _lastToolTip;
private SensorTreeItemViewModel(SensorTreeItemKind kind, AppSettings? settings)
{
@@ -259,10 +263,38 @@ public sealed class SensorTreeItemViewModel : ViewModelBase
public void RefreshValues()
{
OnPropertyChanged(nameof(Value));
OnPropertyChanged(nameof(Min));
OnPropertyChanged(nameof(Max));
OnPropertyChanged(nameof(ToolTip));
// Value/Min/Max/ToolTip are computed (no backing field), so raise PropertyChanged only when the formatted text
// actually changed. Unconditionally notifying all four for every item on every update tick made the native
// binding engine re-marshal unchanged values across the boundary continuously — most sensors don't change each
// tick, so this cuts the per-tick interop churn (and its retained wrappers) by a large factor.
string value = Value;
if (value != _lastValue)
{
_lastValue = value;
OnPropertyChanged(nameof(Value));
}
string min = Min;
if (min != _lastMin)
{
_lastMin = min;
OnPropertyChanged(nameof(Min));
}
string max = Max;
if (max != _lastMax)
{
_lastMax = max;
OnPropertyChanged(nameof(Max));
}
string toolTip = ToolTip;
if (toolTip != _lastToolTip)
{
_lastToolTip = toolTip;
OnPropertyChanged(nameof(ToolTip));
}
foreach (SensorTreeItemViewModel child in Children)
child.RefreshValues();
}