JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R34 — disable_region_sampling's "one blocking wait on the device" does not wait #43

New Issue
Closed
opened 2026-08-23 03:44:55 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R34 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R34 — disable_region_sampling's "one blocking wait on the device" does not wait

severity: low
verdict: PLAUSIBLE
where: tools/local-emulator/run-e2e.sh:308-310 (branch)
scenario: adb shell stop does not clear sys.boot_completed, so the wait loop exits immediately; the 30-iteration service-check loop below is what actually waits. Harmless today; the comment misleads whoever later trims that loop — the exact ordering failure :277-282 says cost a whole run.
evidence: Code read; property behaviour under stop on these exact images not verified (the known idiom is setprop sys.boot_completed 0 first, precisely because stop does not clear it).
fix: setprop sys.boot_completed 0 before stop, or delete the line and fix the comment.
risk: Trivial.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R34** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R34 — disable_region_sampling's "one blocking wait on the device" does not wait severity: low verdict: PLAUSIBLE where: tools/local-emulator/run-e2e.sh:308-310 (branch) scenario: adb shell stop does not clear sys.boot_completed, so the wait loop exits immediately; the 30-iteration service-check loop below is what actually waits. Harmless today; the comment misleads whoever later trims that loop — the exact ordering failure :277-282 says cost a whole run. evidence: Code read; property behaviour under stop on these exact images not verified (the known idiom is setprop sys.boot_completed 0 first, precisely because stop does not clear it). fix: setprop sys.boot_completed 0 before stop, or delete the line and fix the comment. risk: Trivial. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 05:21:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut bug plausible sev:low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#43