JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R31 — kill -9 "${EMU_PID:-0}" signals the whole process group if EMU_PID is ever empty #40

New Issue
Closed
opened 2026-08-23 03:44:54 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R31 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R31 — kill -9 "${EMU_PID:-0}" signals the whole process group if EMU_PID is ever empty

severity: low
verdict: PLAUSIBLE
where: tools/local-emulator/run-e2e.sh:199-200 (main) / :346-347 (branch)
scenario: POSIX: pid 0 = sender's whole process group. EMU_PID=$! is empty (not unset) if the background launch failed to create a job; :-0 converts empty to the group-kill form. The kill -0 wait loop has the same shape and would burn its full 30s against the group.
evidence: Code read; the empty-EMU_PID precondition not demonstrable without running the script.
fix: [ -n "${EMU_PID:-}" ] || return 0 at the top of stop_emulator; drop the :-0 defaults.
risk: None; strictly narrowing.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R31** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R31 — kill -9 "${EMU_PID:-0}" signals the whole process group if EMU_PID is ever empty severity: low verdict: PLAUSIBLE where: tools/local-emulator/run-e2e.sh:199-200 (main) / :346-347 (branch) scenario: POSIX: pid 0 = sender's whole process group. EMU_PID=$! is empty (not unset) if the background launch failed to create a job; :-0 converts empty to the group-kill form. The kill -0 wait loop has the same shape and would burn its full 30s against the group. evidence: Code read; the empty-EMU_PID precondition not demonstrable without running the script. fix: [ -n "${EMU_PID:-}" ] || return 0 at the top of stop_emulator; drop the :-0 defaults. risk: None; strictly narrowing. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 05:21:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut bug plausible sev:low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#40