JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R26 — ConversionViewModelProbeFailureTest:131 is a dead assertion #35

New Issue
Closed
opened 2026-08-23 03:44:52 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-08-23 03:44:52 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R26 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R26 — ConversionViewModelProbeFailureTest:131 is a dead assertion

severity: low
verdict: PLAUSIBLE (argued from types, not demonstrated)
where: app/src/test/java/org/libremediaconverter/convert/ConversionViewModelProbeFailureTest.kt:131
scenario: assertNull((ready as? Failed)) where ready was produced by an awaitState predicate requiring Ready — sibling sealed subtypes, the cast can never succeed, the assertion can never fire. If production landed on Failed the test would fail at awaitState's timeout instead. Dead line, not a coverage hole — both D14 mutations bite this class.
evidence: Types read; surrounding predicate does the real work.
fix: Delete the line, or assert on state.value after a bounded settle() as the OOM test at :102 does.
risk: None.

Cut: below — held for manual review: product decision, CI/workflow, hardware, or PLAUSIBLE verdict.

🤖 Generated with Claude Code

_Finding **R26** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R26 — ConversionViewModelProbeFailureTest:131 is a dead assertion severity: low verdict: PLAUSIBLE (argued from types, not demonstrated) where: app/src/test/java/org/libremediaconverter/convert/ConversionViewModelProbeFailureTest.kt:131 scenario: assertNull((ready as? Failed)) where ready was produced by an awaitState predicate requiring Ready — sibling sealed subtypes, the cast can never succeed, the assertion can never fire. If production landed on Failed the test would fail at awaitState's timeout instead. Dead line, not a coverage hole — both D14 mutations bite this class. evidence: Types read; surrounding predicate does the real work. fix: Delete the line, or assert on state.value after a bounded settle() as the OOM test at :102 does. risk: None. --- **Cut:** `below` — held for manual review: product decision, CI/workflow, hardware, or PLAUSIBLE verdict. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels backlog bug plausible sev:low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#35