JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R25 — Reattachment's KDoc describes as current a defect fixed in the commit before it #34

New Issue
Closed
opened 2026-08-23 03:44:51 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R25 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R25 — Reattachment's KDoc describes as current a defect fixed in the commit before it

severity: low
verdict: CONFIRMED (lead verified commit order)
where: app/src/main/java/org/libremediaconverter/work/Reattachment.kt:107-110
scenario: "a result the user dismissed with 'Start over' currently keeps its staged file, so today it can be offered again on the next launch" — false when written: cfd705a (reset deletes) precedes ec969c4 (this file). A maintainer could re-fix D2.
evidence: git log order on the two files; reset() paths read.
fix: Rewrite: the file is deleted on Start over; the surviving gap is a reset() whose delete was cancelled with the Activity (which the sweep's KDoc already names).
risk: None.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R25** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R25 — Reattachment's KDoc describes as current a defect fixed in the commit before it severity: low verdict: CONFIRMED (lead verified commit order) where: app/src/main/java/org/libremediaconverter/work/Reattachment.kt:107-110 scenario: "a result the user dismissed with 'Start over' currently keeps its staged file, so today it can be offered again on the next launch" — false when written: cfd705a (reset deletes) precedes ec969c4 (this file). A maintainer could re-fix D2. evidence: git log order on the two files; reset() paths read. fix: Rewrite: the file is deleted on Start over; the surviving gap is a reset() whose delete was cancelled with the Activity (which the sweep's KDoc already names). risk: None. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 04:52:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut confirmed documentation sev:low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#34