JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R21 — After a failed save, the only button the UI offers destroys the file the code deliberately kept #30

New Issue
Closed
opened 2026-08-23 03:44:50 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-08-23 03:44:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R21 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R21 — After a failed save, the only button the UI offers destroys the file the code deliberately kept

severity: low-medium
verdict: CONFIRMED (lead re-read all four sites)
where: app/src/main/java/org/libremediaconverter/convert/ConversionViewModel.kt:414-421 vs ConverterScreen.kt:221-231; same shape JoinViewModel.kt:232-239 / JoinScreen.kt:164-174
scenario: 40-minute transcode done; Save fails (destination full). save()'s onFailure deliberately keeps pendingStaged ("deleting here would destroy the work") and sets Failed — whose screen branch renders exactly one control: "Start over" -> reset() -> discardStaged() deletes it. No Save button on Failed. The only rescue is process death -> reattach (unadvertised, <24h sweep window).
evidence: All four sites read by lead and reviewer. No JVM test asserts what Failed offers.
fix: Failed variant carrying the staged handle when the failure came from save(); render "Try saving again" beside "Start over". Decide what Start-over does from that state (delete — but only once the alternative was offered).
risk: Touches the state machine and both screens; a Failed that carries a file is a new invariant for reset(). VM half JVM-testable now; screen half needs createComposeRule.

LOW

Cut: below — held for manual review: product decision, CI/workflow, hardware, or PLAUSIBLE verdict.

🤖 Generated with Claude Code

_Finding **R21** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R21 — After a failed save, the only button the UI offers destroys the file the code deliberately kept severity: low-medium verdict: CONFIRMED (lead re-read all four sites) where: app/src/main/java/org/libremediaconverter/convert/ConversionViewModel.kt:414-421 vs ConverterScreen.kt:221-231; same shape JoinViewModel.kt:232-239 / JoinScreen.kt:164-174 scenario: 40-minute transcode done; Save fails (destination full). save()'s onFailure deliberately keeps pendingStaged ("deleting here would destroy the work") and sets Failed — whose screen branch renders exactly one control: "Start over" -> reset() -> discardStaged() deletes it. No Save button on Failed. The only rescue is process death -> reattach (unadvertised, <24h sweep window). evidence: All four sites read by lead and reviewer. No JVM test asserts what Failed offers. fix: Failed variant carrying the staged handle when the failure came from save(); render "Try saving again" beside "Start over". Decide what Start-over does from that state (delete — but only once the alternative was offered). risk: Touches the state machine and both screens; a Failed that carries a file is a new invariant for reset(). VM half JVM-testable now; screen half needs createComposeRule. --- ## LOW --- **Cut:** `below` — held for manual review: product decision, CI/workflow, hardware, or PLAUSIBLE verdict. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels backlog bug confirmed sev:medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#30