JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R16 — The branch puts API 37 in the default sweep, so a bare run-e2e.sh exits non-zero by design, and the doc does not say so #25

New Issue
Closed
opened 2026-08-23 03:44:48 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:48 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R16 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R16 — The branch puts API 37 in the default sweep, so a bare run-e2e.sh exits non-zero by design, and the doc does not say so

severity: medium
verdict: CONFIRMED
where: tools/local-emulator/run-e2e.sh:85, :430-448 (branch); docs/local-emulator.md:193 (branch)
scenario: Default APIS becomes (33 34 35 36 37); API 37 is expected-red (branch's own comment: "expected to be red"); a red level sets overall=1 and the script exits it. Anyone running the sweep from habit/wrapper/hook gets a permanent red exit and either ignores it or debugs a normal state. The doc documents the new default with no mention of the exit code.
evidence: Branch diff read; exit path traced (:443, :460).
fix: Document at :193, or exclude API 37's expected failure set from overall when it matches exactly. Decide whether "expected red" belongs in an exit code — the script's comment argues yes; then it must be documented.
risk: Suppressing 37's contribution needs exact-set comparison or it hides a genuine third failure.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R16** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R16 — The branch puts API 37 in the default sweep, so a bare run-e2e.sh exits non-zero by design, and the doc does not say so severity: medium verdict: CONFIRMED where: tools/local-emulator/run-e2e.sh:85, :430-448 (branch); docs/local-emulator.md:193 (branch) scenario: Default APIS becomes (33 34 35 36 37); API 37 is expected-red (branch's own comment: "expected to be red"); a red level sets overall=1 and the script exits it. Anyone running the sweep from habit/wrapper/hook gets a permanent red exit and either ignores it or debugs a normal state. The doc documents the new default with no mention of the exit code. evidence: Branch diff read; exit path traced (:443, :460). fix: Document at :193, or exclude API 37's expected failure set from overall when it matches exactly. Decide whether "expected red" belongs in an exit code — the script's comment argues yes; then it must be documented. risk: Suppressing 37's contribution needs exact-set comparison or it hides a genuine third failure. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 05:21:30 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut confirmed documentation sev:medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#25