JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R15 — The audit's "On testing these" section is falsified in four separate statements #24

New Issue
Closed
opened 2026-08-23 03:44:47 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R15 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R15 — The audit's "On testing these" section is falsified in four separate statements

severity: medium
verdict: CONFIRMED
where: docs/defect-audit.md:6, :52-54, :822, :833-834, :836-838
scenario: A contributor re-does merged work: the section says the JVM set has "exactly one dependency" (now five, incl. pinned robolectric 4.16.1 with reasoning at libs.versions.toml:70-76), that the testOptions block "does not exist" (build.gradle.kts:105-110), that OutputPublisher/ViewModels/Workers have "no JVM unit tests at all" (26 new files), and that work-testing/compose-ui-test have "zero users" (eight users now; only espresso still zero).
evidence: All four checked against main by the docs reviewer; test-dep pinning independently confirmed correct by the tests reviewer.
fix: Re-date the section as "state at 903b43c and what the follow-up did", or delete it — its proposal has been executed. Decide whether the preamble (:6, :52-54) is inside the "not rewritten as fixes land" exemption, which currently covers only entry bodies.
risk: :52-54 is also the derivation of the ~31% figure — keep the reasoning, re-date it.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R15** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R15 — The audit's "On testing these" section is falsified in four separate statements severity: medium verdict: CONFIRMED where: docs/defect-audit.md:6, :52-54, :822, :833-834, :836-838 scenario: A contributor re-does merged work: the section says the JVM set has "exactly one dependency" (now five, incl. pinned robolectric 4.16.1 with reasoning at libs.versions.toml:70-76), that the testOptions block "does not exist" (build.gradle.kts:105-110), that OutputPublisher/ViewModels/Workers have "no JVM unit tests at all" (26 new files), and that work-testing/compose-ui-test have "zero users" (eight users now; only espresso still zero). evidence: All four checked against main by the docs reviewer; test-dep pinning independently confirmed correct by the tests reviewer. fix: Re-date the section as "state at 903b43c and what the follow-up did", or delete it — its proposal has been executed. Decide whether the preamble (:6, :52-54) is inside the "not rewritten as fixes land" exemption, which currently covers only entry bodies. risk: :52-54 is also the derivation of the ~31% figure — keep the reasoning, re-date it. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 04:22:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #45 (merged). Verified: docs-only diff, every replacement claim checked against the source of truth rather than another document.

Fixed in #45 (merged). Verified: docs-only diff, every replacement claim checked against the source of truth rather than another document.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut confirmed documentation sev:medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#24