JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R14 — The audit asserts instrumented tests cannot run locally in two places and records the opposite in a third #23

New Issue
Closed
opened 2026-08-23 03:44:47 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R14 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R14 — The audit asserts instrumented tests cannot run locally in two places and records the opposite in a third

severity: medium
verdict: CONFIRMED
where: docs/defect-audit.md:824-826, :437, versus :801-804
scenario: :824-826 is load-bearing — it justifies "pure seams plus Robolectric" for all follow-up work by impossibility, but 22c7914 (merged) makes API 33-36 run locally; the justification now stands on speed, not impossibility. :437 says D6's test "runs on CI, not locally" — also false now.
evidence: Both statements read; docs/local-emulator.md:3-5 and its sweep table record four green local levels; the audit's own :801-804 cites it.
fix: Point both at tools/local-emulator/run-e2e.sh; restate the pure-seams choice on its surviving grounds. Decide whether "needs device confirmation" labels now admit a local emulator as sufficient evidence. Do not weaken the API-37-on-Pixel rule, which survives.
risk: Low.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R14** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R14 — The audit asserts instrumented tests cannot run locally in two places and records the opposite in a third severity: medium verdict: CONFIRMED where: docs/defect-audit.md:824-826, :437, versus :801-804 scenario: :824-826 is load-bearing — it justifies "pure seams plus Robolectric" for all follow-up work by impossibility, but 22c7914 (merged) makes API 33-36 run locally; the justification now stands on speed, not impossibility. :437 says D6's test "runs on CI, not locally" — also false now. evidence: Both statements read; docs/local-emulator.md:3-5 and its sweep table record four green local levels; the audit's own :801-804 cites it. fix: Point both at tools/local-emulator/run-e2e.sh; restate the pure-seams choice on its surviving grounds. Decide whether "needs device confirmation" labels now admit a local emulator as sufficient evidence. Do not weaken the API-37-on-Pixel rule, which survives. risk: Low. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 04:22:11 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #45 (merged). Verified: docs-only diff, every replacement claim checked against the source of truth rather than another document.

Fixed in #45 (merged). Verified: docs-only diff, every replacement claim checked against the source of truth rather than another document.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut confirmed documentation sev:medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#23