JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R11 — 7db3200's backup/device-transfer exclusions have no gate of any kind #20

New Issue
Closed
opened 2026-08-23 03:44:46 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:46 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R11 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R11 — 7db3200's backup/device-transfer exclusions have no gate of any kind

severity: medium
verdict: CONFIRMED
where: app/src/main/res/xml/data_extraction_rules.xml
scenario: Filed under D11 "docs and scaffold", but it changes what leaves the device: androidx.work.workdb(+wal,shm) and androidx.work.util.preferences.xml excluded from cloud-backup AND device-transfer; backup_rules.xml deleted. The file's own comment states the stake: a restored queue makes a fresh install "come up reattached to a job the user never ran on it" (reattach queries by tag on launch). Reverting the whole file to pre-commit boilerplate leaves unit tests AND lint green — a future edit dropping the excludes ships silently.
evidence: Mutation M30: full revert -> BUILD SUCCESSFUL, 257/257, lintDebug clean. No CI grep hit for backup|extraction|workdb.
fix: JVM test parsing the XML off app/src/main/res/xml/, asserting the four paths under both sections. A resource-shape assertion, but the failure mode is invisible until a device transfer.
risk: Pins spelling; a WorkManager db rename fails it — which is correct, since that rename would also silently un-exclude the queue. JVM-verifiable.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R11** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R11 — 7db3200's backup/device-transfer exclusions have no gate of any kind severity: medium verdict: CONFIRMED where: app/src/main/res/xml/data_extraction_rules.xml scenario: Filed under D11 "docs and scaffold", but it changes what leaves the device: androidx.work.workdb(+wal,shm) and androidx.work.util.preferences.xml excluded from cloud-backup AND device-transfer; backup_rules.xml deleted. The file's own comment states the stake: a restored queue makes a fresh install "come up reattached to a job the user never ran on it" (reattach queries by tag on launch). Reverting the whole file to pre-commit boilerplate leaves unit tests AND lint green — a future edit dropping the excludes ships silently. evidence: Mutation M30: full revert -> BUILD SUCCESSFUL, 257/257, lintDebug clean. No CI grep hit for backup|extraction|workdb. fix: JVM test parsing the XML off app/src/main/res/xml/, asserting the four paths under both sections. A resource-shape assertion, but the failure mode is invisible until a device transfer. risk: Pins spelling; a WorkManager db rename fails it — which is correct, since that rename would also silently un-exclude the queue. JVM-verifiable. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 04:52:48 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut confirmed documentation sev:medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#20