JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

"Prefer hardware" is offered as a distinct choice and routes identically to Automatic #178

New Issue
Open
opened 2026-09-02 02:15:23 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-09-02 02:15:23 +00:00 (Migrated from github.com)
Copy Link
Copy Source

"Prefer hardware" is offered as a distinct choice and routes identically to Automatic

ConversionRouter.kt:73-78:

when (request.enginePreference) {
    EnginePreference.FORCE_SOFTWARE -> return Decision(Engine.FFMPEG, Reason.USER_FORCED_SOFTWARE)
    else -> Unit
}

EnginePreference.PREFER_HARDWARE falls into else -> Unit, which is exactly what AUTO does.

Meanwhile ConverterScreen.kt:590-603 renders all three EnginePreference.entries in a picker,
labelled "Prefer hardware" — a real, selectable option that reads as different from
"Automatic".

ConversionRouterTest never constructs a request with PREFER_HARDWARE; only AUTO (by default)
and FORCE_SOFTWARE appear.

Why this is filed as a question rather than closed with a test

Both readings are defensible and the repo records neither:

  • If the identity is intentional — the control is aspirational, or "prefer" is honestly a no-op
    because the router already prefers hardware whenever it can — then the picker is offering a
    distinction that does not exist, and the fix is to the UI or the KDoc.
  • If it is a missed wiring, the fix is in the router.

A test written now would freeze whichever answer the author happened to assume, which is the failure
mode docs/coverage-read-findings.md names for F1 and F5. The decision comes first.

Related in shape: #68 (a KDoc promising a switch that does not exist) and F2 in
docs/coverage-read-findings.md.

## "Prefer hardware" is offered as a distinct choice and routes identically to Automatic `ConversionRouter.kt:73-78`: ```kotlin when (request.enginePreference) { EnginePreference.FORCE_SOFTWARE -> return Decision(Engine.FFMPEG, Reason.USER_FORCED_SOFTWARE) else -> Unit } ``` `EnginePreference.PREFER_HARDWARE` falls into `else -> Unit`, which is exactly what `AUTO` does. Meanwhile `ConverterScreen.kt:590-603` renders all three `EnginePreference.entries` in a picker, labelled **"Prefer hardware"** — a real, selectable option that reads as different from "Automatic". `ConversionRouterTest` never constructs a request with `PREFER_HARDWARE`; only `AUTO` (by default) and `FORCE_SOFTWARE` appear. ## Why this is filed as a question rather than closed with a test Both readings are defensible and the repo records neither: - If the identity is **intentional** — the control is aspirational, or "prefer" is honestly a no-op because the router already prefers hardware whenever it can — then the picker is offering a distinction that does not exist, and the fix is to the UI or the KDoc. - If it is a **missed wiring**, the fix is in the router. A test written now would freeze whichever answer the author happened to assume, which is the failure mode `docs/coverage-read-findings.md` names for F1 and F5. **The decision comes first.** Related in shape: **#68** (a KDoc promising a switch that does not exist) and F2 in `docs/coverage-read-findings.md`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#178