JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R8 — The join half of D8 — the constant name the audit lists first — has no test that ConcatWorker asks for a per-job name #17

New Issue
Closed
opened 2026-08-23 03:44:44 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:44 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R8 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R8 — The join half of D8 — the constant name the audit lists first — has no test that ConcatWorker asks for a per-job name

severity: medium
verdict: CONFIRMED
where: app/src/main/java/org/libremediaconverter/work/ConcatWorker.kt:62
scenario: Reverting ConcatWorker to the exact constant the audit's D8 table names ("joined.${format.extension}" — collides for any two joins of one format) leaves all 257 tests green. PerJobStagingTest drives only the real ConversionWorker; StagingNamesTest pins only the pure function.
evidence: Mutation M32 full suite: VACUOUS 257/257 green. Control M31 (same reversion, conversion side) bites PerJobStagingTest 2/3 + WorkerOutputNamingTest 1/2 + DeniedForegroundStartTest 1/4.
fix: Mirror PerJobStagingTest for ConcatWorker: two TestListenableWorkerBuilder runs, different ids, same format -> two files in staging. Scaffolding exists in DeniedForegroundStartTest.concatWorker().
risk: ConcatEngine is native, so assert on staged names after doWork() (WorkerCancellationTest's pattern), not on success. JVM-verifiable.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R8** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R8 — The join half of D8 — the constant name the audit lists first — has no test that ConcatWorker asks for a per-job name severity: medium verdict: CONFIRMED where: app/src/main/java/org/libremediaconverter/work/ConcatWorker.kt:62 scenario: Reverting ConcatWorker to the exact constant the audit's D8 table names ("joined.${format.extension}" — collides for any two joins of one format) leaves all 257 tests green. PerJobStagingTest drives only the real ConversionWorker; StagingNamesTest pins only the pure function. evidence: Mutation M32 full suite: VACUOUS 257/257 green. Control M31 (same reversion, conversion side) bites PerJobStagingTest 2/3 + WorkerOutputNamingTest 1/2 + DeniedForegroundStartTest 1/4. fix: Mirror PerJobStagingTest for ConcatWorker: two TestListenableWorkerBuilder runs, different ids, same format -> two files in staging. Scaffolding exists in DeniedForegroundStartTest.concatWorker(). risk: ConcatEngine is native, so assert on staged names after doWork() (WorkerCancellationTest's pattern), not on success. JVM-verifiable. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 04:52:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut bug confirmed sev:medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#17