JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

The display-name fallback reaches the user's save dialog and has never run #169

New Issue
Closed
opened 2026-09-02 02:14:53 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-09-02 02:14:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

The display-name fallback can reach the user's save dialog, untested

ConversionWorker.kt:63 — inputData.getString(KEY_DISPLAY_NAME) ?: "input". JaCoCo: mi=2,
1 of 2 branches missed. Every test in app/src/test/java/org/libremediaconverter/work supplies
KEY_DISPLAY_NAME, so the fallback has never run.

It is not cosmetic. The value feeds the foreground-notification title and, through
outputNameFor(displayName, spec) (:147), the KEY_SUGGESTED_NAME in the success output — i.e.
the filename offered in the user's save dialog. The same read appears again at :343 in
getForegroundInfo.

The work

One test. RefusedJobTest already has the fixture:
workerWithout(key) (app/src/test/java/org/libremediaconverter/work/RefusedJobTest.kt:199-211),
built by map subtraction. Run a worker without KEY_DISPLAY_NAME, assert the job succeeds and
KEY_SUGGESTED_NAME starts with input.

Land this in the same PR as the runMedia3OrFallBack ticket — same file, same harness.

Acceptance: the mutation that must go red

Change the fallback string from "input" to anything else.

## The display-name fallback can reach the user's save dialog, untested `ConversionWorker.kt:63` — `inputData.getString(KEY_DISPLAY_NAME) ?: "input"`. JaCoCo: `mi=2`, 1 of 2 branches missed. Every test in `app/src/test/java/org/libremediaconverter/work` supplies `KEY_DISPLAY_NAME`, so the fallback has never run. It is not cosmetic. The value feeds the foreground-notification title *and*, through `outputNameFor(displayName, spec)` (`:147`), the `KEY_SUGGESTED_NAME` in the success output — i.e. the filename offered in the user's save dialog. The same read appears again at `:343` in `getForegroundInfo`. ## The work One test. `RefusedJobTest` already has the fixture: `workerWithout(key)` (`app/src/test/java/org/libremediaconverter/work/RefusedJobTest.kt:199-211`), built by map subtraction. Run a worker without `KEY_DISPLAY_NAME`, assert the job succeeds and `KEY_SUGGESTED_NAME` starts with `input`. Land this in the same PR as the `runMedia3OrFallBack` ticket — same file, same harness. ## Acceptance: the mutation that must go red Change the fallback string from `"input"` to anything else.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#169