JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R4 — tools/api-37-emulator tells the pre-release Pixel check to expect 49 tests; main has 57 #13

New Issue
Closed
opened 2026-08-23 03:44:43 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R4 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R4 — tools/api-37-emulator tells the pre-release Pixel check to expect 49 tests; main has 57

severity: high
verdict: CONFIRMED (lead re-counted: branch 49 @Test, main 57)
where: docs/api-37-emulator-crash.md:370-374 (branch tools/api-37-emulator)
scenario: API 37 has no CI row, so the physical-Pixel run is the only gate. The branch instructs: "expect 49 / 0 / 0 / 2, and if you get 40, you are on an old checkout." Merged onto main (57 @Test — +8 from ReattachOnLaunchTest via 159320d), the release runner gets 57 and an explicit instruction saying a mismatch means a broken checkout. The branch was correct for its own base and false the moment it merges — the exact failure mode its own second commit exists to prevent.
evidence: grep -rc '@Test' app/src/androidTest: main = 57, branch = 49. ReattachOnLaunchTest.kt carries the 8.
fix: Rebase and re-derive, or replace the absolute count with the derivation ("total = grep -rc '@Test' on your checkout; 2 skips expected"). Decide whether this document owns a suite-size number at all — it moved three times in one day.
risk: The branch's 49-test result headline and 47-of-49 arithmetic (branch :6, :226-227) also need re-labelling or re-measuring on rebase.

MEDIUM

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R4** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R4 — tools/api-37-emulator tells the pre-release Pixel check to expect 49 tests; main has 57 severity: high verdict: CONFIRMED (lead re-counted: branch 49 @Test, main 57) where: docs/api-37-emulator-crash.md:370-374 (branch tools/api-37-emulator) scenario: API 37 has no CI row, so the physical-Pixel run is the only gate. The branch instructs: "expect 49 / 0 / 0 / 2, and if you get 40, you are on an old checkout." Merged onto main (57 @Test — +8 from ReattachOnLaunchTest via 159320d), the release runner gets 57 and an explicit instruction saying a mismatch means a broken checkout. The branch was correct for its own base and false the moment it merges — the exact failure mode its own second commit exists to prevent. evidence: grep -rc '@Test' app/src/androidTest: main = 57, branch = 49. ReattachOnLaunchTest.kt carries the 8. fix: Rebase and re-derive, or replace the absolute count with the derivation ("total = grep -rc '@Test' on your checkout; 2 skips expected"). Decide whether this document owns a suite-size number at all — it moved three times in one day. risk: The branch's 49-test result headline and 47-of-49 arithmetic (branch :6, :226-227) also need re-labelling or re-measuring on rebase. --- ## MEDIUM --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 05:21:28 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.

Fixed in #47 (merged). Validated with two stub harnesses rather than a sweep — shellcheck is not installed on this host, and no emulator was booted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut confirmed documentation sev:high
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#13