JMR-dev/LibreMediaConverter
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

R2 — The FAILED exclusion is only tested with pathless FAILED jobs; a FAILED job carrying a file would be reattached to unnoticed #11

New Issue
Closed
opened 2026-08-23 03:44:42 +00:00 by JMR-dev · 1 comment
JMR-dev commented 2026-08-23 03:44:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Finding R2 from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: scratchpad/overnight/REVIEW.md.

R2 — The FAILED exclusion is only tested with pathless FAILED jobs; a FAILED job carrying a file would be reattached to unnoticed

severity: high
verdict: CONFIRMED
where: app/src/main/java/org/libremediaconverter/work/Reattachment.kt:173; app/src/test/java/org/libremediaconverter/work/ReattachmentTest.kt:32-36,127
scenario: Not D16 (the design question) — this is the guard's test coverage. Every FAILED fixture in the suite has outputPath=null. A regression that ranks FAILED like SUCCEEDED-with-file passes all 257 tests. Live shape: a job killed mid-write leaves a partial in staging (the audit's own 2 MB Pixel orphan); under the regression the user is offered a truncated file with a Save button.
evidence: Mutation M05b (FAILED -> RESULT when outputPath!=null && outputExists): paired run 20/20 green, full suite 257/257 green. Control (blunt FAILED -> RESULT) bites 2/20 — the narrow form is what slips through. Lead read ReattachmentTest:32-36 and confirmed the fixture shape.
fix: assertNull(Reattachment.choose(listOf(job(state = FAILED, outputPath = "/cache/out.mp4", outputExists = true)))). One line.
risk: None; strictly stronger assertion of the documented rule. JVM-verifiable.

Cut: above — worked autonomously overnight.

🤖 Generated with Claude Code

_Finding **R2** from the overnight max-effort review (Fable lead, Opus sub-agents). Full report: `scratchpad/overnight/REVIEW.md`._ ### R2 — The FAILED exclusion is only tested with pathless FAILED jobs; a FAILED job carrying a file would be reattached to unnoticed severity: high verdict: CONFIRMED where: app/src/main/java/org/libremediaconverter/work/Reattachment.kt:173; app/src/test/java/org/libremediaconverter/work/ReattachmentTest.kt:32-36,127 scenario: Not D16 (the design question) — this is the guard's test coverage. Every FAILED fixture in the suite has outputPath=null. A regression that ranks FAILED like SUCCEEDED-with-file passes all 257 tests. Live shape: a job killed mid-write leaves a partial in staging (the audit's own 2 MB Pixel orphan); under the regression the user is offered a truncated file with a Save button. evidence: Mutation M05b (FAILED -> RESULT when outputPath!=null && outputExists): paired run 20/20 green, full suite 257/257 green. Control (blunt FAILED -> RESULT) bites 2/20 — the narrow form is what slips through. Lead read ReattachmentTest:32-36 and confirmed the fixture shape. fix: assertNull(Reattachment.choose(listOf(job(state = FAILED, outputPath = "/cache/out.mp4", outputExists = true)))). One line. risk: None; strictly stronger assertion of the documented rule. JVM-verifiable. --- **Cut:** `above` — worked autonomously overnight. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
JMR-dev commented 2026-08-23 04:52:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.

Fixed in #48 (merged). Each fix is pinned by a mutation that was applied and reverted individually — the failure text is in the PR body. Suite 257 -> 276, 0 failures.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
above-cut
Worked autonomously overnight: local, JVM-verifiable, no product decision
 accessibility
Barrier affecting people with disabilities
 backlog
Held for manual review: product/UX call, CI/workflow, hardware, or unverifiable here
 bug
Something isn't working
 confirmed
Reviewer demonstrated the defect
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 plausible
Reviewer could not fully demonstrate it; treat as unproven
 question
Further information is requested
 sev:high
High severity
 sev:low
Low severity
 sev:medium
Medium severity
 wontfix
This will not be worked on
No labels above-cut bug confirmed sev:high
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMediaConverter#11