Re-derive the API 37 carrier counts, and correct what #226 left behind

The 2026-09-06 re-check of the instrumented suite. Every drifted line it found came from #226, the last PR of the e2e read's own wave. The suite is 70 tests in 14 classes, 6 carrying @FailsOnEmulatorApi37, gating leg 64. The committed baseline says 6 and the advisory job agrees. Four places still said five carriers of 69: - CLAUDE.md, three sites - FailsOnEmulatorApi37.kt's KDoc - two comments in status_check.yml The gating figure is what hid it. 69 - 5 and 70 - 6 are both 64, so the one number a reader checks against a run had not moved -- which is exactly why CLAUDE.md says to derive these rather than remember them. Two KDoc claims in SafPickerRoundTripTest described a draft rather than the code. The save test says MP3 was chosen so the setup could not depend on device codecs; the code converts at the default MP4_H265/FAST, which routes on canEncode(H265). The negation of the stated reason was true. That is E1 and E3's failure mode committed by the wave that found it, so it is written down as such rather than quietly corrected. Neither picker test has ever reported on the advisory leg. The marker's KDoc said the picker test fails there behind the rotation test; with six carriers the rotation test truncates the run first, and both advisory runs since #226 -- 34042397320 and 34043502322 -- report expected: 6, received: 4, the four being the three Media3 tests plus the rotation. The save test is therefore marked by inheritance, not measurement, and both KDocs now say so. FixtureDocumentsProvider.deletedDocumentIds() has no callers: #226 proved D4's premise and drove only the success path, so deletePartialOutput against a real DocumentsProvider is still asserted nowhere. Filed as #250 with the forcing condition and the mutation; the accessor is kept with a KDoc naming that ticket rather than removed and re-added. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-06 11:16:15 -05:00
parent 1f21557b8d
commit 54167c052f
6 changed files with 154 additions and 44 deletions
@@ -245,7 +245,17 @@ public final class FixtureDocumentsProvider extends DocumentsProvider {
        destinationFile(documentId).delete();
    }

-    /** Document ids {@link #deleteDocument} was called with, newest last. */
+    /**
+     * Document ids {@link #deleteDocument} was called with, newest last.
+     *
+     * <p><b>Nothing reads this yet, and that is recorded rather than hidden (#250).</b> It was
+     * added with #226 to assert {@code OutputPublisher.deletePartialOutput} — D4's cleanup — against
+     * a real {@code DocumentsProvider}. #226 only reached the <i>success</i> path, so the
+     * {@code catch} that calls it is still asserted only against {@code FakeSafProvider} under
+     * Robolectric. It is kept because the forcing condition is one {@code openDestination} override
+     * away and #250 says exactly what to add; if that ticket is closed any other way, delete this
+     * and {@link #DELETED} with it rather than leaving an accessor implying coverage.
+     */
    public static List<String> deletedDocumentIds() {
        synchronized (DELETED) {
            return new ArrayList<>(DELETED);