From 1b220856ab1d4c148060fecd1c9a5aafe93b5896 Mon Sep 17 00:00:00 2001 From: Jason Ross Date: Tue, 25 Aug 2026 10:14:34 -0500 Subject: [PATCH] Say 37.0 is the choice, not the only api-level that exists R19 raised two things about this comment. One resolved itself: it used to explain why the matrix had no API 37 row at all, and #56 added the gating row, so that half is gone. The other survived, and this is it. The comment read api-level must be "37.0". A bare 37 is not an SDK package and fails during setup The second sentence is true and was measured -- it cost a run to find. The first overstates it. What must be true is that the api-level is a POINT release; 37.0 is one of several. api37-debug.yml's own input descriptions already say so: API level, as the SDK spells it. 37.0, 37.1, 37.2-beta3, 36 ... System image target. android-37.1 and 37.2-beta* ship ONLY as google_apis_ps16k and docs/api-37-emulator-crash.md measures android-37.0 rev 6 and android-37.1 rev 8 side by side, both aborting. So the repo already knows 37.1 exists and behaves the same; only this comment implied otherwise. That matters for the reader it is written for. Someone debugging this row and wondering whether a newer image helps reads "must be 37.0" as a constraint and stops. The measured answer is that it does not help, which is a better thing to learn than a rule that is not one -- and the ps16k-only wrinkle above 37.0 is the detail that would actually bite them. Comment only. No job, matrix, filter or gating behaviour changes. actionlint clean at the pinned digest. Closes #28. --- .github/workflows/status_check.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/status_check.yml b/.github/workflows/status_check.yml index f3b3355..7b890fc 100644 --- a/.github/workflows/status_check.yml +++ b/.github/workflows/status_check.yml @@ -280,8 +280,13 @@ jobs: # docs/api-37-emulator-crash.md has the per-method measurements, and the # correction that produced them. # - # api-level must be "37.0". A bare 37 is not an SDK package and fails - # during setup, which cost a run to discover. + # api-level must be a POINT release. A bare 37 is not an SDK package and + # fails during setup, which cost a run to discover. `37.0` is the choice + # here rather than the only option: `37.1` and `37.2-beta*` exist and + # abort the same way, and api37-debug.yml's inputs document both, with + # the wrinkle that above 37.0 they ship only as google_apis_ps16k. + # docs/api-37-emulator-crash.md measures 37.0 rev 6 and 37.1 rev 8 side + # by side, so pinning 37.0 is a decision, not a constraint. # # notAnnotation removes the three tests that do not pass on this image; they # run in the advisory job below, off the same marker so they cannot end up