test(compose): Robolectric JVM tests — app shell & lock gate host (batch 9/9) #384

Closed
opened 2026-07-06 20:07:35 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-07-06 20:07:35 +00:00 (Migrated from github.com)

Convert the app shell / gate hosts to Robolectric JVM Compose tests where tractable and drop the covered files from jacocoNonJvmTestableSurface.

Files (globs): LibreMailApp*, AppLockGateHost*

Notes: hardest. LibreMailApp is the NavHost + onboarding/main graphs + StartupCrashPrompt, with multiple hiltViewModel()s and real navigation — investigate Robolectric nav-testing feasibility and convert the tractable parts (StartupCrashPrompt is internal and already has StartupCrashPromptTest; graph-level nav may be better left to the instrumented OnboardingFlowTest). AppLockGateHost is a VM-driven gate wrapper. Only remove a glob when its file is genuinely JVM-covered; if navigation testing proves impractical, keep LibreMailApp excluded and document why (this is the acceptable exception). Mirror LibreMailBottomBarTest, StartupCrashPromptTest.

Recommended dispatch order: 9/9.


Part of the Robolectric Compose umbrella #373. Infra + PoC landed in PR #375 (Robolectric 4.16.1, testOptions.unitTests.isIncludeAndroidResources=true, src/test/resources/robolectric.properties pins sdk=36, v2 androidx.compose.ui.test.junit4.v2.createComposeRule).

Pattern to follow: app/src/test/kotlin/org/libremail/ui/onboarding/AddAnotherAccountScreenJvmTest.kt — @RunWith(RobolectricTestRunner) + @GraphicsMode(GraphicsMode.Mode.NATIVE) + @Config(sdk = [36]), v2 createComposeRule(), in the test (JVM) source set — NOT androidTest.

Acceptance criteria

  • Robolectric JVM Compose tests for each file below, covering its render + interaction/branch logic.
  • Remove the matching **/<File>* glob(s) from jacocoNonJvmTestableSurface in app/build.gradle.kts as each file gains genuine JVM coverage.
  • Keep the existing instrumented androidTest test(s) — the instrumented E2E stays.
  • Do NOT raise the JaCoCo floor (jacocoLineCoverageFloor, currently 0.79) — the re-ratchet is the final #373 step.
  • Fast gate green: assembleDebug + testDebugUnitTest + jacocoTestCoverageVerification + compileDebugAndroidTestKotlin + lintDebug + ktlintCheck + detekt.
Convert the app shell / gate hosts to Robolectric JVM Compose tests where tractable and drop the covered files from `jacocoNonJvmTestableSurface`. **Files (globs):** `LibreMailApp*`, `AppLockGateHost*` **Notes:** hardest. `LibreMailApp` is the `NavHost` + onboarding/main graphs + `StartupCrashPrompt`, with multiple `hiltViewModel()`s and real navigation — investigate Robolectric nav-testing feasibility and convert the tractable parts (`StartupCrashPrompt` is `internal` and already has StartupCrashPromptTest; graph-level nav may be better left to the instrumented OnboardingFlowTest). `AppLockGateHost` is a VM-driven gate wrapper. **Only remove a glob when its file is genuinely JVM-covered**; if navigation testing proves impractical, keep `LibreMailApp` excluded and document why (this is the acceptable exception). Mirror LibreMailBottomBarTest, StartupCrashPromptTest. Recommended dispatch order: **9/9**. --- Part of the Robolectric Compose umbrella #373. Infra + PoC landed in PR #375 (Robolectric 4.16.1, `testOptions.unitTests.isIncludeAndroidResources=true`, `src/test/resources/robolectric.properties` pins `sdk=36`, v2 `androidx.compose.ui.test.junit4.v2.createComposeRule`). **Pattern to follow:** `app/src/test/kotlin/org/libremail/ui/onboarding/AddAnotherAccountScreenJvmTest.kt` — `@RunWith(RobolectricTestRunner)` + `@GraphicsMode(GraphicsMode.Mode.NATIVE)` + `@Config(sdk = [36])`, v2 `createComposeRule()`, in the **`test`** (JVM) source set — NOT `androidTest`. **Acceptance criteria** - Robolectric JVM Compose tests for each file below, covering its render + interaction/branch logic. - Remove the matching `**/<File>*` glob(s) from `jacocoNonJvmTestableSurface` in `app/build.gradle.kts` as each file gains genuine JVM coverage. - Keep the existing instrumented `androidTest` test(s) — the instrumented E2E stays. - **Do NOT raise the JaCoCo floor** (`jacocoLineCoverageFloor`, currently 0.79) — the re-ratchet is the final #373 step. - Fast gate green: `assembleDebug` + `testDebugUnitTest` + `jacocoTestCoverageVerification` + `compileDebugAndroidTestKotlin` + `lintDebug` + `ktlintCheck` + `detekt`.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMail#384