test(compose): Robolectric JVM tests — reader screen, WebView caveat (batch 6/9) #381

Closed
opened 2026-07-06 20:07:24 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-07-06 20:07:24 +00:00 (Migrated from github.com)

Convert the reader screen to a Robolectric JVM Compose test and drop it from jacocoNonJvmTestableSurface.

Files (globs): ReaderScreen*

Notes / caveat: ReaderScreen embeds HtmlBody (a hardened WebView via AndroidView). Under Robolectric the WebView is a shadow that does not truly render HTML, so target the screen chrome instead — top bar, star/delete/attachment actions, loading/error/empty states, remote-image toggle — and assert HtmlBody is present, not its rendered content. HtmlBody.kt itself stays excluded (already logic-tested via HtmlBodyTest/InlineImageResolverTest, and its render is a shadowed WebView). Document the WebView limitation in the test. Mirror ReaderScreenTest for the chrome interactions.

Recommended dispatch order: 6/9.


Part of the Robolectric Compose umbrella #373. Infra + PoC landed in PR #375 (Robolectric 4.16.1, testOptions.unitTests.isIncludeAndroidResources=true, src/test/resources/robolectric.properties pins sdk=36, v2 androidx.compose.ui.test.junit4.v2.createComposeRule).

Pattern to follow: app/src/test/kotlin/org/libremail/ui/onboarding/AddAnotherAccountScreenJvmTest.kt — @RunWith(RobolectricTestRunner) + @GraphicsMode(GraphicsMode.Mode.NATIVE) + @Config(sdk = [36]), v2 createComposeRule(), in the test (JVM) source set — NOT androidTest.

Acceptance criteria

  • Robolectric JVM Compose tests for each file below, covering its render + interaction/branch logic.
  • Remove the matching **/<File>* glob(s) from jacocoNonJvmTestableSurface in app/build.gradle.kts as each file gains genuine JVM coverage.
  • Keep the existing instrumented androidTest test(s) — the instrumented E2E stays.
  • Do NOT raise the JaCoCo floor (jacocoLineCoverageFloor, currently 0.79) — the re-ratchet is the final #373 step.
  • Fast gate green: assembleDebug + testDebugUnitTest + jacocoTestCoverageVerification + compileDebugAndroidTestKotlin + lintDebug + ktlintCheck + detekt.
Convert the reader screen to a Robolectric JVM Compose test and drop it from `jacocoNonJvmTestableSurface`. **Files (globs):** `ReaderScreen*` **Notes / caveat:** `ReaderScreen` embeds `HtmlBody` (a hardened `WebView` via `AndroidView`). Under Robolectric the `WebView` is a **shadow that does not truly render HTML**, so target the screen chrome instead — top bar, star/delete/attachment actions, loading/error/empty states, remote-image toggle — and assert `HtmlBody` is present, not its rendered content. `HtmlBody.kt` itself stays excluded (already logic-tested via HtmlBodyTest/InlineImageResolverTest, and its render is a shadowed WebView). Document the WebView limitation in the test. Mirror ReaderScreenTest for the chrome interactions. Recommended dispatch order: **6/9**. --- Part of the Robolectric Compose umbrella #373. Infra + PoC landed in PR #375 (Robolectric 4.16.1, `testOptions.unitTests.isIncludeAndroidResources=true`, `src/test/resources/robolectric.properties` pins `sdk=36`, v2 `androidx.compose.ui.test.junit4.v2.createComposeRule`). **Pattern to follow:** `app/src/test/kotlin/org/libremail/ui/onboarding/AddAnotherAccountScreenJvmTest.kt` — `@RunWith(RobolectricTestRunner)` + `@GraphicsMode(GraphicsMode.Mode.NATIVE)` + `@Config(sdk = [36])`, v2 `createComposeRule()`, in the **`test`** (JVM) source set — NOT `androidTest`. **Acceptance criteria** - Robolectric JVM Compose tests for each file below, covering its render + interaction/branch logic. - Remove the matching `**/<File>*` glob(s) from `jacocoNonJvmTestableSurface` in `app/build.gradle.kts` as each file gains genuine JVM coverage. - Keep the existing instrumented `androidTest` test(s) — the instrumented E2E stays. - **Do NOT raise the JaCoCo floor** (`jacocoLineCoverageFloor`, currently 0.79) — the re-ratchet is the final #373 step. - Fast gate green: `assembleDebug` + `testDebugUnitTest` + `jacocoTestCoverageVerification` + `compileDebugAndroidTestKotlin` + `lintDebug` + `ktlintCheck` + `detekt`.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMail#381