Notes: Welcome/License/Lock are stateless callback-driven — trivial. ContactsAccessScreen/BatteryOptimizationScreen take an OnboardingViewModel; prefer testing the stateless ContactsAccessContent, and for the VM wrappers pass a fake/real OnboardingViewModel exposing the needed StateFlows. Mirror LicenseScreenTest, LockScreenTest, ContactsAccessStepTest, BatteryOptimizationStepTest. OnboardingWelcomeScreen fires NotificationPermissionEffect (a permission launcher) — drive WelcomeContent directly to avoid it, as its instrumented test does.
Recommended dispatch order: 2/9.
Part of the Robolectric Compose umbrella #373. Infra + PoC landed in PR #375 (Robolectric 4.16.1, testOptions.unitTests.isIncludeAndroidResources=true, src/test/resources/robolectric.properties pins sdk=36, v2 androidx.compose.ui.test.junit4.v2.createComposeRule).
Pattern to follow:app/src/test/kotlin/org/libremail/ui/onboarding/AddAnotherAccountScreenJvmTest.kt — @RunWith(RobolectricTestRunner) + @GraphicsMode(GraphicsMode.Mode.NATIVE) + @Config(sdk = [36]), v2 createComposeRule(), in the test (JVM) source set — NOT androidTest.
Acceptance criteria
Robolectric JVM Compose tests for each file below, covering its render + interaction/branch logic.
Remove the matching **/<File>* glob(s) from jacocoNonJvmTestableSurface in app/build.gradle.kts as each file gains genuine JVM coverage.
Keep the existing instrumented androidTest test(s) — the instrumented E2E stays.
Do NOT raise the JaCoCo floor (jacocoLineCoverageFloor, currently 0.79) — the re-ratchet is the final #373 step.
Convert the stateless onboarding + lock screens to Robolectric JVM Compose tests and drop them from `jacocoNonJvmTestableSurface`.
**Files (globs):** `OnboardingWelcomeScreen*` (incl. `WelcomeContent`), `LicenseScreen*`, `LockScreen*`, `ContactsAccessScreen*`, `BatteryOptimizationScreen*`
**Notes:** Welcome/License/Lock are stateless callback-driven — trivial. `ContactsAccessScreen`/`BatteryOptimizationScreen` take an `OnboardingViewModel`; prefer testing the stateless `ContactsAccessContent`, and for the VM wrappers pass a fake/real `OnboardingViewModel` exposing the needed `StateFlow`s. Mirror LicenseScreenTest, LockScreenTest, ContactsAccessStepTest, BatteryOptimizationStepTest. `OnboardingWelcomeScreen` fires `NotificationPermissionEffect` (a permission launcher) — drive `WelcomeContent` directly to avoid it, as its instrumented test does.
Recommended dispatch order: **2/9**.
---
Part of the Robolectric Compose umbrella #373. Infra + PoC landed in PR #375 (Robolectric 4.16.1, `testOptions.unitTests.isIncludeAndroidResources=true`, `src/test/resources/robolectric.properties` pins `sdk=36`, v2 `androidx.compose.ui.test.junit4.v2.createComposeRule`).
**Pattern to follow:** `app/src/test/kotlin/org/libremail/ui/onboarding/AddAnotherAccountScreenJvmTest.kt` — `@RunWith(RobolectricTestRunner)` + `@GraphicsMode(GraphicsMode.Mode.NATIVE)` + `@Config(sdk = [36])`, v2 `createComposeRule()`, in the **`test`** (JVM) source set — NOT `androidTest`.
**Acceptance criteria**
- Robolectric JVM Compose tests for each file below, covering its render + interaction/branch logic.
- Remove the matching `**/<File>*` glob(s) from `jacocoNonJvmTestableSurface` in `app/build.gradle.kts` as each file gains genuine JVM coverage.
- Keep the existing instrumented `androidTest` test(s) — the instrumented E2E stays.
- **Do NOT raise the JaCoCo floor** (`jacocoLineCoverageFloor`, currently 0.79) — the re-ratchet is the final #373 step.
- Fast gate green: `assembleDebug` + `testDebugUnitTest` + `jacocoTestCoverageVerification` + `compileDebugAndroidTestKotlin` + `lintDebug` + `ktlintCheck` + `detekt`.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Convert the stateless onboarding + lock screens to Robolectric JVM Compose tests and drop them from
jacocoNonJvmTestableSurface.Files (globs):
OnboardingWelcomeScreen*(incl.WelcomeContent),LicenseScreen*,LockScreen*,ContactsAccessScreen*,BatteryOptimizationScreen*Notes: Welcome/License/Lock are stateless callback-driven — trivial.
ContactsAccessScreen/BatteryOptimizationScreentake anOnboardingViewModel; prefer testing the statelessContactsAccessContent, and for the VM wrappers pass a fake/realOnboardingViewModelexposing the neededStateFlows. Mirror LicenseScreenTest, LockScreenTest, ContactsAccessStepTest, BatteryOptimizationStepTest.OnboardingWelcomeScreenfiresNotificationPermissionEffect(a permission launcher) — driveWelcomeContentdirectly to avoid it, as its instrumented test does.Recommended dispatch order: 2/9.
Part of the Robolectric Compose umbrella #373. Infra + PoC landed in PR #375 (Robolectric 4.16.1,
testOptions.unitTests.isIncludeAndroidResources=true,src/test/resources/robolectric.propertiespinssdk=36, v2androidx.compose.ui.test.junit4.v2.createComposeRule).Pattern to follow:
app/src/test/kotlin/org/libremail/ui/onboarding/AddAnotherAccountScreenJvmTest.kt—@RunWith(RobolectricTestRunner)+@GraphicsMode(GraphicsMode.Mode.NATIVE)+@Config(sdk = [36]), v2createComposeRule(), in thetest(JVM) source set — NOTandroidTest.Acceptance criteria
**/<File>*glob(s) fromjacocoNonJvmTestableSurfaceinapp/build.gradle.ktsas each file gains genuine JVM coverage.androidTesttest(s) — the instrumented E2E stays.jacocoLineCoverageFloor, currently 0.79) — the re-ratchet is the final #373 step.assembleDebug+testDebugUnitTest+jacocoTestCoverageVerification+compileDebugAndroidTestKotlin+lintDebug+ktlintCheck+detekt.