JMR-dev/LibreMail
1
0
Fork 0
Code Issues 40 Pull Requests 2 Actions Packages Projects Releases 2 Wiki Activity

fix(data): append id tiebreaker to paged message ORDER BY (pagination correctness) #311

New Issue
Closed
opened 2026-07-04 06:52:47 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-07-04 06:52:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Phase-3 review (LOW/correctness, trivial). The four PagingSource queries in MessageDao(:43,59,79,94) ORDER BY timestampMillis DESC with no unique tiebreaker; timestampMillis isn't unique (bulk mail shares a second) so tied rows at a LIMIT/OFFSET page boundary can duplicate/skip. Fix (free): ORDER BY timestampMillis DESC, id (id is PK; no new index).

Phase-3 review (LOW/correctness, trivial). The four `PagingSource` queries in `MessageDao`(:43,59,79,94) `ORDER BY timestampMillis DESC` with no unique tiebreaker; timestampMillis isn't unique (bulk mail shares a second) so tied rows at a LIMIT/OFFSET page boundary can duplicate/skip. **Fix (free):** `ORDER BY timestampMillis DESC, id` (id is PK; no new index).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compliance
Infrastructure
P0
Priority P0 (P0=highest for CI runners, P9=lowest)
 P1
Priority P1 (P0=highest for CI runners, P9=lowest)
 P2
Priority P2 (P0=highest for CI runners, P9=lowest)
 P3
Priority P3 (P0=highest for CI runners, P9=lowest)
 P4
Priority P4 (P0=highest for CI runners, P9=lowest)
 P5
Priority P5 (P0=highest for CI runners, P9=lowest)
 P6
Priority P6 (P0=highest for CI runners, P9=lowest)
 P7
Priority P7 (P0=highest for CI runners, P9=lowest)
 P8
Priority P8 (P0=highest for CI runners, P9=lowest)
 P9
Priority P9 (P0=highest for CI runners, P9=lowest)
 Release
broken
Deprioritize below all P-levels; higher-priority PRs may preempt it. Coordinator/owner only.
 bug
Something isn't working
 dequeued
documentation
Improvements or additions to documentation
 donotmerge
duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 queued
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMail#311