review(domain/platform): below-cut nits #307

Closed
opened 2026-07-04 06:50:29 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-07-04 06:50:29 +00:00 (Migrated from github.com)

Phase-3 review — below-the-cut LOW findings (Backlog):

  • MainActivity.kt:118: exported activity consumes private ACTION_OPEN_MESSAGE without caller verification — any app can drive the NavHost to open an arbitrary message id (limited: renders in-app only, app-lock gates). Accept as inherent to an exported email client, or trust only the app's own PendingIntent.
  • MailNotifier.kt:129: per-message notification id = messageId.hashCode() can collide → a new-mail notification silently replaces an earlier unacknowledged one. Use a stable collision-free id (persisted per-account counter).
Phase-3 review — below-the-cut LOW findings (Backlog): - `MainActivity.kt:118`: exported activity consumes private `ACTION_OPEN_MESSAGE` without caller verification — any app can drive the NavHost to open an arbitrary message id (limited: renders in-app only, app-lock gates). Accept as inherent to an exported email client, or trust only the app's own PendingIntent. - `MailNotifier.kt:129`: per-message notification id = `messageId.hashCode()` can collide → a new-mail notification silently replaces an earlier unacknowledged one. Use a stable collision-free id (persisted per-account counter).
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMail#307