JMR-dev/LibreMail
1
0
Fork 0
Code Issues 40 Pull Requests 2 Actions Packages Projects Releases 2 Wiki Activity

test(coverage): high-value branch-coverage additions (RichText, VMs, MailRepositoryImpl) #289

New Issue
Closed
opened 2026-07-04 05:44:19 +00:00 by JMR-dev · 0 comments
JMR-dev commented 2026-07-04 05:44:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

From the Phase-2 audit §4 — files already ≥95% line but leaking real branches; all pure JVM logic, high value. No emulator.

  • richtext/RichTextEditing — 35 missed branches; uncovered removeLink/remapLink/styleAt.
  • richtext/RichTextHtmlParser — 43 missed branches; parseCssColor (4/7), richAlignFor, inline/block tag edges.
  • ui/mailbox/MailboxViewModel — 40 missed branches.
  • ui/compose/ComposeViewModel — 37 missed branches.
  • data/repository/MailRepositoryImpl — 81 missed branches; esp. null-role-folder fallbacks in archive/reportSpam/trash + resolveRoleFolder (cheap "role folder missing" test).
  • data/repository/AccountRepositoryImpl — reorderAccounts (1 line, #240 path).
  • Smaller: mail/HtmlToText (12 br), reporting/DiagnosticsCollector (13 br), data/SignatureBlock (5 br), reporting/AppLog (4 br).

Validate :app:testDebugUnitTest; aim to raise branch coverage on each. No emulator.

From the Phase-2 audit §4 — files already ≥95% line but leaking real branches; all pure JVM logic, high value. **No emulator.** - `richtext/RichTextEditing` — 35 missed branches; uncovered `removeLink/remapLink/styleAt`. - `richtext/RichTextHtmlParser` — 43 missed branches; `parseCssColor` (4/7), `richAlignFor`, inline/block tag edges. - `ui/mailbox/MailboxViewModel` — 40 missed branches. - `ui/compose/ComposeViewModel` — 37 missed branches. - `data/repository/MailRepositoryImpl` — 81 missed branches; esp. null-role-folder fallbacks in `archive/reportSpam/trash` + `resolveRoleFolder` (cheap "role folder missing" test). - `data/repository/AccountRepositoryImpl` — `reorderAccounts` (1 line, #240 path). - Smaller: `mail/HtmlToText` (12 br), `reporting/DiagnosticsCollector` (13 br), `data/SignatureBlock` (5 br), `reporting/AppLog` (4 br). Validate `:app:testDebugUnitTest`; aim to raise branch coverage on each. No emulator.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compliance
Infrastructure
P0
Priority P0 (P0=highest for CI runners, P9=lowest)
 P1
Priority P1 (P0=highest for CI runners, P9=lowest)
 P2
Priority P2 (P0=highest for CI runners, P9=lowest)
 P3
Priority P3 (P0=highest for CI runners, P9=lowest)
 P4
Priority P4 (P0=highest for CI runners, P9=lowest)
 P5
Priority P5 (P0=highest for CI runners, P9=lowest)
 P6
Priority P6 (P0=highest for CI runners, P9=lowest)
 P7
Priority P7 (P0=highest for CI runners, P9=lowest)
 P8
Priority P8 (P0=highest for CI runners, P9=lowest)
 P9
Priority P9 (P0=highest for CI runners, P9=lowest)
 Release
broken
Deprioritize below all P-levels; higher-priority PRs may preempt it. Coordinator/owner only.
 bug
Something isn't working
 dequeued
documentation
Improvements or additions to documentation
 donotmerge
duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 queued
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
JMR-dev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: JMR-dev/LibreMail#289