MailProvider.ICLOUD (domain/model/MailProvider.kt) has no twoFactorHelpUrl, unlike GMAIL. Apple's app-specific-password support article
(https://support.apple.com/en-us/102654) actually covers both the two-factor-authentication
prerequisite and the app-password creation steps on one page. iCloud's current appPasswordHelpUrl points at a generic Apple ID sign-in/management page
(https://appleid.apple.com), not a specific instructions page — so today's iCloud screen gives
noticeably less guidance than Gmail's.
Scope
Add twoFactorHelpUrl = "https://support.apple.com/en-us/102654" to MailProvider.ICLOUD.
The conditional "2FA help" button in AppPasswordSetupScreen.kt (~lines 163-171, provider.twoFactorHelpUrl?.let { ... }) is already generic, not Gmail-specific, so iCloud
picks it up automatically once the field is set.
Since Apple's article covers both the 2FA prerequisite and the app-password steps at the
same URL, decide whether iCloud also needs its own instructionsUrl (the field proposed in #155) pointing at the same article, or whether the 2FA button alone is sufficient — having
both buttons point at an identical URL would look redundant. Resolve this together with #155's field design.
Check the button label: the existing string (app_password_2fa_help = "How to turn on
2-Step Verification") is Google's terminology. Apple calls the equivalent
"Two-Factor Authentication" — decide whether to keep one generic string or add a
per-provider label.
Acceptance criteria
iCloud's guided setup screen shows a 2FA/app-password help link using Apple's official support
article, positioned the same way Gmail's is (see #152 for the intended ordering).
Button copy reads naturally for Apple's terminology (doesn't say "2-Step Verification" if that
reads oddly for iCloud).
Coordinate with #155 (may introduce a shared instructionsUrl field) and #152 (button ordering
— once iCloud has a twoFactorHelpUrl, #152's fix applies here too).
## Context
`MailProvider.ICLOUD` (`domain/model/MailProvider.kt`) has no `twoFactorHelpUrl`, unlike
`GMAIL`. Apple's app-specific-password support article
(https://support.apple.com/en-us/102654) actually covers both the two-factor-authentication
prerequisite and the app-password creation steps on one page. iCloud's current
`appPasswordHelpUrl` points at a generic Apple ID sign-in/management page
(`https://appleid.apple.com`), not a specific instructions page — so today's iCloud screen gives
noticeably less guidance than Gmail's.
## Scope
- [ ] Add `twoFactorHelpUrl = "https://support.apple.com/en-us/102654"` to `MailProvider.ICLOUD`.
The conditional "2FA help" button in `AppPasswordSetupScreen.kt` (~lines 163-171,
`provider.twoFactorHelpUrl?.let { ... }`) is already generic, not Gmail-specific, so iCloud
picks it up automatically once the field is set.
- [ ] Since Apple's article covers both the 2FA prerequisite and the app-password steps at the
same URL, decide whether iCloud also needs its own `instructionsUrl` (the field proposed in
#155) pointing at the same article, or whether the 2FA button alone is sufficient — having
both buttons point at an identical URL would look redundant. Resolve this together with
#155's field design.
- [ ] Check the button label: the existing string (`app_password_2fa_help` = "How to turn on
2-Step Verification") is Google's terminology. Apple calls the equivalent
"Two-Factor Authentication" — decide whether to keep one generic string or add a
per-provider label.
## Acceptance criteria
- iCloud's guided setup screen shows a 2FA/app-password help link using Apple's official support
article, positioned the same way Gmail's is (see #152 for the intended ordering).
- Button copy reads naturally for Apple's terminology (doesn't say "2-Step Verification" if that
reads oddly for iCloud).
## Relevant files
- `domain/model/MailProvider.kt`, `ui/accountsetup/AppPasswordSetupScreen.kt`,
`res/values/strings.xml` (`app_password_2fa_help`, `app_password_intro_icloud`).
## Dependencies
Coordinate with #155 (may introduce a shared `instructionsUrl` field) and #152 (button ordering
— once iCloud has a `twoFactorHelpUrl`, #152's fix applies here too).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Context
MailProvider.ICLOUD(domain/model/MailProvider.kt) has notwoFactorHelpUrl, unlikeGMAIL. Apple's app-specific-password support article(https://support.apple.com/en-us/102654) actually covers both the two-factor-authentication
prerequisite and the app-password creation steps on one page. iCloud's current
appPasswordHelpUrlpoints at a generic Apple ID sign-in/management page(
https://appleid.apple.com), not a specific instructions page — so today's iCloud screen givesnoticeably less guidance than Gmail's.
Scope
twoFactorHelpUrl = "https://support.apple.com/en-us/102654"toMailProvider.ICLOUD.The conditional "2FA help" button in
AppPasswordSetupScreen.kt(~lines 163-171,provider.twoFactorHelpUrl?.let { ... }) is already generic, not Gmail-specific, so iCloudpicks it up automatically once the field is set.
same URL, decide whether iCloud also needs its own
instructionsUrl(the field proposed in#155) pointing at the same article, or whether the 2FA button alone is sufficient — having
both buttons point at an identical URL would look redundant. Resolve this together with
#155's field design.
app_password_2fa_help= "How to turn on2-Step Verification") is Google's terminology. Apple calls the equivalent
"Two-Factor Authentication" — decide whether to keep one generic string or add a
per-provider label.
Acceptance criteria
article, positioned the same way Gmail's is (see #152 for the intended ordering).
reads oddly for iCloud).
Relevant files
domain/model/MailProvider.kt,ui/accountsetup/AppPasswordSetupScreen.kt,res/values/strings.xml(app_password_2fa_help,app_password_intro_icloud).Dependencies
Coordinate with #155 (may introduce a shared
instructionsUrlfield) and #152 (button ordering— once iCloud has a
twoFactorHelpUrl, #152's fix applies here too).