From 664d79a42724a42d42d7f77d5d9ab2a9a33b6889 Mon Sep 17 00:00:00 2001 From: Jason Ross Date: Fri, 3 Jul 2026 18:48:25 -0500 Subject: [PATCH] fix(test): pass accountRepository to DiagnosticsCollector in CrashReporterInstallTest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DiagnosticsCollector gained a 4th constructor param (accountRepository) for the PII-free account summary, but CrashReporterInstallTest still constructed it with 3 args — a compile error that broke the Unit tests and Static analysis gates. Add the AccountRepository mock with observeAccounts() stubbed to an empty flow (matching DiagnosticsCollectorTest) and pass it to both call sites. Co-Authored-By: Claude Opus 4.8 --- .../org/libremail/reporting/CrashReporterInstallTest.kt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/src/test/kotlin/org/libremail/reporting/CrashReporterInstallTest.kt b/app/src/test/kotlin/org/libremail/reporting/CrashReporterInstallTest.kt index d72c745..a06194c 100644 --- a/app/src/test/kotlin/org/libremail/reporting/CrashReporterInstallTest.kt +++ b/app/src/test/kotlin/org/libremail/reporting/CrashReporterInstallTest.kt @@ -4,12 +4,14 @@ package org.libremail.reporting import io.mockk.every import io.mockk.mockk import io.mockk.verify +import kotlinx.coroutines.flow.flowOf import org.junit.After import org.junit.Before import org.junit.Rule import org.junit.Test import org.junit.rules.TemporaryFolder import org.libremail.data.settings.SettingsRepository +import org.libremail.domain.repository.AccountRepository import kotlin.test.assertEquals import kotlin.test.assertTrue @@ -30,6 +32,9 @@ class CrashReporterInstallTest { every { versionCode } returns 1L } private val settingsRepository = mockk() + private val accountRepository = mockk { + every { observeAccounts() } returns flowOf(emptyList()) + } private var original: Thread.UncaughtExceptionHandler? = null @@ -49,7 +54,7 @@ class CrashReporterInstallTest { Thread.setDefaultUncaughtExceptionHandler(previous) val store = ReportStore(tempFolder.root) val buffer = RingLogBuffer() - val collector = DiagnosticsCollector(appVersion, settingsRepository, buffer) + val collector = DiagnosticsCollector(appVersion, settingsRepository, accountRepository, buffer) val reporter = CrashReporter(collector, store, buffer) reporter.install() @@ -70,7 +75,7 @@ class CrashReporterInstallTest { Thread.setDefaultUncaughtExceptionHandler(mockk(relaxed = true)) val store = ReportStore(tempFolder.root) val buffer = RingLogBuffer() - val collector = DiagnosticsCollector(appVersion, settingsRepository, buffer) + val collector = DiagnosticsCollector(appVersion, settingsRepository, accountRepository, buffer) val reporter = CrashReporter(collector, store, buffer) reporter.install() val installed = requireNotNull(Thread.getDefaultUncaughtExceptionHandler())